Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new preference and api for bsky app state; also put preference updates within transactional lock regions #2492

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented May 14, 2024

  • Adds #bskyAppStatePref preference
  • Adds bskyAppQueueNudges(nudges: string|string[])
  • Adds bskyAppDismissNudges(nudges: string|string[])
  • Adds bskyAppSetActiveProgressGuide(guide: {guide: string, ...})
  • Wraps updatePreferences in a lock region to avoid transaction clobbering in the future

To be used by the bsky app to track nudges that the user can dismiss (things like "Introducing DMs!") and to run progress guides. Not meant to be used by other clients, so explicitly namespaced with bksyApp within the API.

@pfrazee pfrazee changed the title Add new preference and api for dismissed nudges Add new preference and api for bsky app state; also put preference updates within transactional lock regions Jul 2, 2024
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock makes sense

@pfrazee pfrazee merged commit bc861a2 into main Jul 2, 2024
10 checks passed
@pfrazee pfrazee deleted the nudges-prefs branch July 2, 2024 01:23
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
estrattonbailey added a commit that referenced this pull request Jul 16, 2024
…cements

* origin/main: (181 commits)
  Minor OAuth client fixes (#2640)
  Version packages (#2639)
  OAuth: 2FA (#2633)
  Version packages (#2622)
  Update data source for `getSuggestedFollowsByActor` (#2630)
  Add in-memory did cache to Ozone backend (#2635)
  Filter out reference lists from `getLists` (#2629)
  lexicons: add missing ozone Tag event type to unions (#2632)
  ✨ Add ozone proxy for getLikes and getRepostedBy (#2624)
  Upgrade pnpm/action-setup in workflows (#2625)
  ✨ Add proxy for user typeahead through ozone (#2612)
  Fix development commands (#2623)
  Add starter packs to post hydration (#2613)
  Social proof blocks (#2603)
  Appview: apply hosting status in getRecord (#2620)
  Add `labelersPref` to `getPreferences` union return types (#2554)
  Version packages (#2618)
  Add new preference and api for bsky app state; also put preference updates within transactional lock regions (#2492)
  remove mentions of sandbox (#2611)
  Appview: simple fix for no-hosted known followers (#2609)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants