Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: versionchooser: use 'fat manifest' to fetch the correct image digest on all architectures #272

Merged
merged 1 commit into from
May 25, 2021

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented May 25, 2021

Previously, the arm builds were showing the remote sha of the x86
images. This fixes that issue by first using the "fat manifest" to get the digest of the correct architecture, and then get the image id using this digest

More information at https://docs.docker.com/registry/spec/manifest-v2-2/

helps #267

(crap. wrong remote)

…igest on all architectures

Previously, the arm builds were showing the remote sha of the x86
images. This fixes that issue.

More information at https://docs.docker.com/registry/spec/manifest-v2-2/
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One may say: The best manifest

@patrickelectric
Copy link
Member

Is there a reason for this PR to exist under BR repository ?

@Williangalvani
Copy link
Member Author

Is there a reason for this PR to exist under BR repository ?

I dont really understand the behavior of Willian of a few moments ago.
image

I'll talk to him and clean this up later.

@Williangalvani Williangalvani merged commit a82ac31 into master May 25, 2021
@Williangalvani Williangalvani deleted the fixsha branch May 25, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants