Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: version chooser: sha information is not useful #267

Closed
patrickelectric opened this issue May 21, 2021 · 6 comments · Fixed by #782
Closed

core: version chooser: sha information is not useful #267

patrickelectric opened this issue May 21, 2021 · 6 comments · Fixed by #782
Assignees
Labels
core Issue related to BlueOS-core enhancement New feature or request

Comments

@patrickelectric
Copy link
Member

patrickelectric commented May 21, 2021

The sha is not our git repository sha, or IMAGE ID, or CONTAINER ID, or dockerhub sha code.
Where they come from, who we should use, where are we going ?
image

@patrickelectric patrickelectric added core Issue related to BlueOS-core enhancement New feature or request labels May 21, 2021
@Williangalvani
Copy link
Member

That is the image id
image

@patrickelectric
Copy link
Member Author

Ok, but my point is that is not clear which sha is this, and how useful is this sha.
How we can compare it with github or dockerhub to know that we are running the latest version ?

@Williangalvani
Copy link
Member

Williangalvani commented May 21, 2021

yeah, dockerhub is weird.
docker image inspect 72814f1ef1cd actually shows a "RepoDigests" key, but the contents don't match dockerhub.
Maybe we're seeing docker/hub-feedback#1925? I can get back to this later.

@patrickelectric
Copy link
Member Author

Ok, I believe that we should work to improve this.
I vote to add the information of our github tag, hash, build time and etc in the docker metadata and use it with others important shas in the webpage in an explicit and clear way.

@Williangalvani
Copy link
Member

Yeah, it seems to be somewhat doable with labels, I'll do some experimentation with it.

@Williangalvani
Copy link
Member

fixed in #782

only displayed in pirate mode, only loaded for tags available both locally and remotely

@rafaellehmkuhl rafaellehmkuhl linked a pull request Feb 22, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issue related to BlueOS-core enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants