-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to recover the system if available size in critical #2325
Try to recover the system if available size in critical #2325
Conversation
7ab37f8
to
65e821a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems correct, and 100MB of threshold feels okay since this is before the system starts up.
How I imagine this patch acting:
- some subsystem spams a log, depleting the disk space
- the user feels the system is unusable
- the user reboots the system
- assuming there is some space left for the kernel and services, the system boots
- critical space is detected
- blueos logs are removed
I can see this patch not working if the kernel or docker fails to start because of insufficient disk space.
It would be nice to:
- inform the user of what happened
- inform us via telemetry system
Now, to really protect the system, we should put the logs into a separate partition from the root (/
), and the log manager service be responsible for cleaning it when necessary.
Check: #2327, #2323, #2326, #1015 The docker is able to start, but everything after that just results in unstable behavior.
|
65e821a
to
0fc078f
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
…er hardcoded Signed-off-by: Patrick José Pereira <[email protected]>
0fc078f
to
5513a47
Compare
Once the system gets in a critical state where the disk is full, it gets in a condition that recover is almost impossible. The system is unstable, the backend services and frontend may not work or be available for the user to recover at all. As a last resource, we delete BlueOS logs if the filesystem.
Fix #2323