Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should delete older extensions once update is done #2326

Closed
patrickelectric opened this issue Jan 20, 2024 · 3 comments · Fixed by #2641
Closed

We should delete older extensions once update is done #2326

patrickelectric opened this issue Jan 20, 2024 · 3 comments · Fixed by #2641
Assignees
Labels
good first issue Good for newcomers

Comments

@patrickelectric
Copy link
Member

patrickelectric commented Jan 20, 2024

The system is not being cleaned, when updating a extension to a newer version we should delete the previous one

@ES-Alexander
Copy link
Collaborator

We definitely need a mechanism for deleting old extension images, but from a "you own what you've paid for" perspective I think users should be given a choice whether they want to (since they may not be able to download them again if the developer has removed the version from hosting), instead of it being forcibly automatic, and they should also be able to roll back to old versions at will (like we allow for the core image with VersionChooser).

@Williangalvani
Copy link
Member

I guess the issue is here:

https://github.com/bluerobotics/BlueOS/blob/master/core/services/kraken/kraken.py#L197-L210

we should do remove(..., True) in order to delete. but we have to do it only after we confirm the pull was successful

@patrickelectric patrickelectric added the good first issue Good for newcomers label Feb 19, 2024
@patrickelectric
Copy link
Member Author

Related to #2365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment