Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whep gathering failure leaks peer connections #3124

Merged
merged 6 commits into from
Mar 10, 2024

automatically call WHEPClient.Close() in case of errors during WHEPCl…

fa24957
Select commit
Loading
Failed to load commit list.
Merged

fix: whep gathering failure leaks peer connections #3124

automatically call WHEPClient.Close() in case of errors during WHEPCl…
fa24957
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 10, 2024 in 0s

55.57% (-0.01%) compared to f8d2343, passed because coverage increased by +0.01% when compared to adjusted base (55.55%)

View this Pull Request on Codecov

55.57% (-0.01%) compared to f8d2343, passed because coverage increased by +0.01% when compared to adjusted base (55.55%)

Details

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 55.57%. Comparing base (f8d2343) to head (fa24957).

Files Patch % Lines
internal/protocols/webrtc/whip_client.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
- Coverage   55.57%   55.57%   -0.01%     
==========================================
  Files         150      150              
  Lines       16822    16839      +17     
==========================================
+ Hits         9349     9358       +9     
- Misses       6735     6744       +9     
+ Partials      738      737       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.