Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whep gathering failure leaks peer connections #3124

Merged
merged 6 commits into from
Mar 10, 2024

automatically call WHEPClient.Close() in case of errors during WHEPCl…

fa24957
Select commit
Loading
Failed to load commit list.
Merged

fix: whep gathering failure leaks peer connections #3124

automatically call WHEPClient.Close() in case of errors during WHEPCl…
fa24957
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 10, 2024 in 0s

42.30% of diff hit (target 55.57%)

View this Pull Request on Codecov

42.30% of diff hit (target 55.57%)

Annotations

Check warning on line 81 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L81

Added line #L81 was not covered by tests

Check warning on line 95 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L95

Added line #L95 was not covered by tests

Check warning on line 106 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L106

Added line #L106 was not covered by tests

Check warning on line 162 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L162

Added line #L162 was not covered by tests

Check warning on line 170 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L170

Added line #L170 was not covered by tests

Check warning on line 177 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L177

Added line #L177 was not covered by tests

Check warning on line 191 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L191

Added line #L191 was not covered by tests

Check warning on line 202 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L202

Added line #L202 was not covered by tests

Check warning on line 213 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L208-L213

Added lines #L208 - L213 were not covered by tests

Check warning on line 215 in internal/protocols/webrtc/whip_client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/protocols/webrtc/whip_client.go#L215

Added line #L215 was not covered by tests