Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix using inline credentials in URLs (#1919) #1966

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 21, 2023

Fixes #1919

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #1966 (9f1b2de) into main (4f098cb) will increase coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 9f1b2de differs from pull request most recent head 315ca54. Consider uploading reports for the commit 315ca54 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1966      +/-   ##
==========================================
+ Coverage   60.95%   61.12%   +0.16%     
==========================================
  Files         108      108              
  Lines       11456    11456              
==========================================
+ Hits         6983     7002      +19     
+ Misses       3959     3938      -21     
- Partials      514      516       +2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 815fa05 into main Jun 21, 2023
@aler9 aler9 deleted the bug/webrtc-inline-credentials branch June 21, 2023 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webrtc read (whep) username:password inline in url fails
2 participants