Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc read (whep) username:password inline in url fails #1919

Closed
1 of 13 tasks
saket424 opened this issue Jun 6, 2023 · 4 comments · Fixed by #1966
Closed
1 of 13 tasks

webrtc read (whep) username:password inline in url fails #1919

saket424 opened this issue Jun 6, 2023 · 4 comments · Fixed by #1966
Labels
bug Something isn't working webrtc

Comments

@saket424
Copy link

saket424 commented Jun 6, 2023

Which version are you using?

v0.23.4

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

whep not working when username:password specified inline with URL

Playing of this url in the browser https://username:[email protected]:8889/endpoint1 results in the following error

(index):112 error: TypeError: Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: whep

Before whep, this webrtc scenario where url contains username:password worked fine in google chrome

Describe how to replicate the issue

  1. start the server
  2. publish with rtsp
  3. read with webrtc over whep using username:password

Did you attach the server logs?

yes
(index):112 error: TypeError: Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: whep

Did you attach a network dump?

no

@Rashid567
Copy link

Same problem with v0.23.5.

Additional information:

  1. If you reload page (via F5) - the username and password will remain in url and you will get the error in the browser console
  2. If you reload page (via editing the URL) - the username and password disapear from the URL, but Authorization header appears and everything is fine

@aler9
Copy link
Member

aler9 commented Jun 21, 2023

Thanks for reporting the issue, this is fixed by #1966

@aler9 aler9 added bug Something isn't working webrtc labels Jun 21, 2023
@aler9
Copy link
Member

aler9 commented Jun 21, 2023

added in v0.23.6

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working webrtc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants