Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Additional Features" section from the app home page. #726

Merged
merged 4 commits into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions src/app/pages/home/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Page } from '../../components/page';
import { SectionContainer, SectionContent } from '../../components/section';
import { AccountCard } from './accountCard';
import { FreeAddonsSection } from './freeAddonsSection';
// import { FreeAddonsSection } from './freeAddonsSection';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just remove this rather than leave it commented. It we bring it back we can find the diff easily enough.

import { HelpCard } from './helpCard';
import './stylesheet.scss';
import { WelcomeSection } from './welcomeSection';
Expand All @@ -10,7 +10,6 @@ const Home = () => {
return (
<Page className="wppbh-home">
<WelcomeSection />
<FreeAddonsSection />
<SectionContainer className="wppbh-account-help-section">
<SectionContent >
<div className="nfd-grid nfd-grid-cols-2 nfd-gap-6">
Expand Down
9 changes: 6 additions & 3 deletions tests/cypress/integration/home.cy.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
// <reference types="Cypress" />

describe('Home Page', function () {
let NewfoldRuntime;

before(() => {
cy.visit('/wp-admin/admin.php?page=' + Cypress.env('pluginId') + '#/home');
cy.window().its('NewfoldRuntime').then(data => {
NewfoldRuntime = data;
});
cy.injectAxe();

});

it('Site Info Exists', () => {
cy
.get('.wppbh-app-site-info').contains('h3', 'bluehost-wordpress-plugin')
.get('.wppbh-app-site-info').contains('h3', NewfoldRuntime.site.title)
.scrollIntoView()
.should('be.visible');
});
Expand All @@ -27,7 +30,7 @@ describe('Home Page', function () {
.should('be.visible');
});

it('Additional Features Section Exists', () => {
it.skip('Additional Features Section Exists', () => {
cy
.get('.nfd-app-section-container').contains('h2', 'Additional Features')
.scrollIntoView()
Expand Down
Loading