Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Additional Features" section from the app home page. #726

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Remove "Additional Features" section from the app home page. #726

merged 4 commits into from
Oct 11, 2023

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Oct 10, 2023 •
edited by bhwpteam
Loading

Proposed changes

Remove the "Additional Features" section from the app's home page as requested by this ticket: https://jira.newfold.com/projects/PRESS1/issues/PRESS1-135

Other changes in this PR as side effects:

  • Skip the "Additional Features" test in Cypress.
  • Dynamically check for the site title instead of checking the static value Bluehost-WordPress-Plugin so the tests can pass everywhere.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani mentioned this pull request Oct 10, 2023
Closed
8 tasks
circlecube
circlecube approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending the tests pass

src/app/pages/home/index.js Outdated
@@ -1,7 +1,7 @@
import { Page } from '../../components/page';
import { SectionContainer, SectionContent } from '../../components/section';
import { AccountCard } from './accountCard';
import { FreeAddonsSection } from './freeAddonsSection';
// import { FreeAddonsSection } from './freeAddonsSection';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just remove this rather than leave it commented. It we bring it back we can find the diff easily enough.

@wpalani wpalani merged commit a6d2037 into develop Oct 11, 2023
2 checks passed
@wpalani wpalani deleted the update/remove-free-addons-section branch October 11, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

@wpscholar wpscholar Awaiting requested review from wpscholar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpalani @circlecube