Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a just setup command for setting up nix #48

Merged
merged 5 commits into from
Apr 29, 2023
Merged

Conversation

xynydev
Copy link
Member

@xynydev xynydev commented Apr 26, 2023

#39

Copy link

@dnkmmr69420 dnkmmr69420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things that should be added

etc/justfile Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about nix profile. Many people use nix profile instead of nix-env.

commands can be like nix profile upgrade '.*'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe have one that uses sudo too

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only know that nixos-rebuild uses sudo and that's only for nixos. We can use also nix-env with sudo because that upgrades the packages in the root profile.

The problem is that we would need to decide between nix-env (and home-manager) and nix profile (and probably fleek) because they can't work on the same profile. (https://discourse.nixos.org/t/home-manager-switch-not-compatible-with-nix-env/12540). We would need to decide if we use flakes for everything or not.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that home-manager can also be a flake (in the fleek documentation) so I think we should use flakes even if they're experimental. I'm busy right now but I probably have time today evening.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even use nix-env, I just use nix profile instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do those nix-env commands still run even if one is not using it? If there are multiple ways of updating nixpkgs that are exclusive and incompatible, I think that'd just have to be ruled out of scope for this.

usr/bin/ublue-nix-install Show resolved Hide resolved
@dnkmmr69420
Copy link

so there should be a `/etc/profile.d/nix-app-icons.sh" so nix apps can have desktop icons

@z0rrn
Copy link

z0rrn commented Apr 29, 2023

I worked on this in my fork. I added the command to update nix profile but removed the command with nix-env. I think we should focus on flakes because they are way better to handle, even for the developers of nix.
The only thing missing is a Warning that they then can't install software with nix-env.

@z0rrn
Copy link

z0rrn commented Apr 29, 2023

Maybe you could merge only the update command and then I create a new pull request so it gets attributed to me.

@xynydev
Copy link
Member Author

xynydev commented Apr 29, 2023

I'll merge this, but should I remove nix-env, I don't quite get the difference and why it should be removed? @federdaemn

Edit: I removed the update command entirely, submit your PR soon and then we'll discuss it. Better yet, submit your PR with the explanation of why nix is updated that way instead of another way.

this will be added in a later PR
@xynydev xynydev merged commit 1d208f6 into main Apr 29, 2023
@z0rrn
Copy link

z0rrn commented Apr 29, 2023

I'm now using this pull for discussion.
Shall we use flakes (and nix profile) or not (and nix-env)?
I'm for flakes because they are easier for the developers and is uses flake references to find packages so a package with the same name works well (https://www.reddit.com/r/NixOS/comments/10s2298/comment/j6zdtfq/). I also think that then it's easier to use fleek.
Any other opinions because if we're using flakes I will need to change the justfile.

@simon-truhter
Copy link

simon-truhter commented Apr 30, 2023

does not work at all for me. breaks login and results in instant logout. also the just command does not work but when i sudo bash the /usr/bin/script it works, but breaks my system. all other just command run just fine.

https://github.com/dnkmmr69420/nix-installer-scripts/blob/main/installer-scripts/silverblue-nix-installer.sh
works fine for me

i really appreciate your effort in progressing but so much stuff is still confusing and a huge time waste when i first assume the error is somehow on my side (i hope it is and you tell me the fix) and than i keep trying figuring stuff out but it still does not work. i dont expect much and have no demands, please dont get me wrong, im here try to support. (wasted good amount of time to try baking additional extensions into the image so that it can be easily enabled by the post install but yeah... unsuccessful sadly)

also this 3-4 repos its just annoying to keep up with where which commits were made. i guess work is mainly done in startingpoint but it would be kind if this repo could then get pinned by uBlue organization

@ubluster
Copy link

ubluster commented Apr 30, 2023

https://github.com/ubluster/nah/commits/main

no clue if @tunix fixed it, but i merged the scripts and made small changes to the setup script like appending --yes
so that the script runs silent, fixed the just file by using sudo bash ahead of running the command

@xynydev xynydev deleted the nix-me-up branch May 2, 2023 13:26
b- pushed a commit to briorg/server that referenced this pull request Oct 13, 2023
…-build#48)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@v3.0.2...v3.0.3)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
RoyalOughtness referenced this pull request in secureblue/secureblue Nov 27, 2023
* feat: add nix install script from bluefin / dnkmmr

* feat: add nix-me-up just cmd from bluefin

* feat: just update nix if installed

* feat: add nix-app-icons.sh
enables desktop icon support by adding to XDG_DATA_DIRS

* chore: remove nix update for now
this will be added in a later PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add a just setup command for setting up nix
5 participants