Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a just setup command for setting up nix #39

Closed
dnkmmr69420 opened this issue Apr 23, 2023 · 15 comments · Fixed by #48
Closed

feat: add a just setup command for setting up nix #39

dnkmmr69420 opened this issue Apr 23, 2023 · 15 comments · Fixed by #48

Comments

@dnkmmr69420
Copy link

title

@z0rrn
Copy link

z0rrn commented Apr 24, 2023

Yes, please. With an official, easy to read setup script.

@dnkmmr69420
Copy link
Author

yes. my script is free for you to use for just.

@dnkmmr69420
Copy link
Author

just should also be able to update nix and also fleek if installed

@xynydev xynydev changed the title add a just setup command for setting up nix feat: add a just setup command for setting up nix Apr 24, 2023
@xynydev
Copy link
Member

xynydev commented Apr 24, 2023

just should also be able to update nix and also fleek if installed

We had this issue on base I believe. My answer; someone who uses Nix should PR it.

@dnkmmr69420
Copy link
Author

What do I even PR?

@xynydev
Copy link
Member

xynydev commented Apr 24, 2023

What do I even PR?

What do you mean by that? This repo, the justfile?, any addition you want, really? I thought you wanted just update to update Nix.

@z0rrn
Copy link

z0rrn commented Apr 24, 2023

We had this issue on base I believe. My answer; someone who uses Nix should PR it.

Do you know the issue on base? I could work on this, likely wednesday.

@xynydev
Copy link
Member

xynydev commented Apr 24, 2023

Do you know the issue on base? I could work on this, likely wednesday.

Apparently it was @dnkmmr69420 that time too https://github.com/ublue-os/base/issues/82.

@z0rrn
Copy link

z0rrn commented Apr 24, 2023

Thanks. I will look at that.

@xynydev
Copy link
Member

xynydev commented Apr 26, 2023

@dnkmmr69420 @federdaemn if yall want just update to update nix stuff too, please either PR it in or reply to PR #48 with the script (needs to check if nix is installed) and I'll put you as co-author

@z0rrn
Copy link

z0rrn commented Apr 26, 2023

I was working on this (https://github.com/federdaemn/2.1-ublue-startingpoint/blob/main/etc/justfile) justfile until now and it includes a command to install home-manager and update both as well too.

I don't know if we should use yours and I will discard my setup-nix command or if we should use mine.

@xynydev
Copy link
Member

xynydev commented Apr 26, 2023

I don't know if we should use yours and I will discard my setup-nix command or if we should use mine.

My nix setup command is the same as bluefin's, so I think we should use that.

I'll look at your nix update command to see if I can incorporate it into just update

@xynydev
Copy link
Member

xynydev commented Apr 26, 2023

@federdaemn How does this look? 01acbf7

@z0rrn
Copy link

z0rrn commented Apr 26, 2023

Looks great to me.
If that's merged I will work on a command to install & update home-manager and fleek. That shouldn't take to long.

@z0rrn
Copy link

z0rrn commented Apr 26, 2023

I your pull request is merged I can start my own for home-manager tomorrow evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants