Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy nil slices correctly in DeepCopy #3944

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: copy nil slices correctly in DeepCopy #3944

merged 1 commit into from
Jan 8, 2025

Conversation

jvmakine
Copy link
Contributor

@jvmakine jvmakine commented Jan 8, 2025

No description provided.

@jvmakine jvmakine requested a review from alecthomas as a code owner January 8, 2025 22:18
@alecthomas alecthomas mentioned this pull request Jan 8, 2025
Open
matt2e
matt2e approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@matt2e matt2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jvmakine jvmakine enabled auto-merge (squash) January 8, 2025 22:25
@jvmakine jvmakine force-pushed the juho/deepcopy-fix branch 2 times, most recently from 302dadf to a35b8fd Compare January 8, 2025 22:58
@jvmakine jvmakine merged commit 33abdd2 into main Jan 8, 2025
61 checks passed
@jvmakine jvmakine deleted the juho/deepcopy-fix branch January 8, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt2e matt2e matt2e approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvmakine @matt2e