fix: copy nill slices correctly in DeepCopy

block · Jan 8, 2025 · 3549f17 · 3549f17
1 parent d7895a1
commit 3549f17
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/common/reflect/reflect.go b/common/reflect/reflect.go
@@ -134,6 +134,9 @@ func copyAny(src any, ptrs map[uintptr]any, copyConf *copyConfig) (dst any) {
 
 	// Special case list.List to handle its internal structure
 	if reflect.TypeOf(src) == reflect.TypeFor[*list.List]() {
+		if v.IsNil() {
+			return nil
+		}
 		return copyList(src.(*list.List), ptrs, copyConf)
 	}
 

diff --git a/common/reflect/reflect_test.go b/common/reflect/reflect_test.go
@@ -88,6 +88,11 @@ func TestCopyStructOfPointers(t *testing.T) {
 	}
 }
 
+func TestNilSliceCopyIsNil(t *testing.T) {
+	copy := DeepCopy([]int(nil))
+	assert.Assert(t, copy == nil)
+}
+
 func testEqualityOfStruct(t *testing.T, expected, actual *structOfPointers) {
 	t.Helper()
 	if expected == nil || actual == nil {