fix: refactor manager.go to use provider key instead of MutableProviders, adds --opvault=VAULT controller flag
#1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
safeer
commented
May 30, 2024
safeer
force-pushed
the
refactor-manager-mutableproviders
branch
from
2a15456 to
7c25bc4
Compare
alecthomas
reviewed
May 30, 2024
safeer
force-pushed
the
refactor-manager-mutableproviders
branch
from
1f5bf82 to
88a5550
Compare
safeer
force-pushed
the
refactor-manager-mutableproviders
branch
from
88a5550 to
afe11e3
Compare
safeer
changed the title
--opvault=VAULT controller flag
wesbillman
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a precursor to #1565. It removes the notion of
MutableProvidersand requires a provider be specified when calling mutable functions in the manager. It also allows a 1Password vault to be set at the controller & main.go levels by using--opvault=VAULT. To operate on 1P secrets via CLI, continue to useftl secret ... --op=VAULT, but this should eventually change to a bool flag.