fix: AdminService, config & secret CLI refactor, --op=VAULT deprecated
#1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
reviewed
May 23, 2024
safeer
force-pushed
the
config-refactor-adminservice
branch
2 times, most recently
from
10b4956 to
678853f
Compare
safeer
commented
May 29, 2024
safeer
added a commit
that referenced
this pull request
May 31, 2024
…ers, adds `--opvault=VAULT` controller flag (#1604) This change is a precursor to #1565. It removes the notion of `MutableProviders` and requires a provider be specified when calling mutable functions in the manager. It also allows a 1Password vault to be set at the controller & main.go levels by using `--opvault=VAULT`. To operate on 1P secrets via CLI, continue to use `ftl secret ... --op=VAULT`, but this should eventually change to a bool flag.
safeer
force-pushed
the
config-refactor-adminservice
branch
2 times, most recently
from
c5343d0 to
2ad12ee
Compare
safeer
changed the title
--op=VAULT deprecated
safeer
force-pushed
the
config-refactor-adminservice
branch
from
2ad12ee to
95706f6
Compare
wesbillman
approved these changes
Jun 3, 2024
Comment on lines
+1
to
+2
| package controller | ||
|
|
There was a problem hiding this comment.
To follow the pattern we have now, maybe this should go in an admin package here in the controller?
There was a problem hiding this comment.
Also, we should add some tests for this new admin :)
There was a problem hiding this comment.
Addressing in a separate PR :)
|
Should this go in? |
safeer
force-pushed
the
config-refactor-adminservice
branch
from
95706f6 to
55441b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1473 by providing an
AdminServiceand refactoringcmd_config.goandcmd_secret.goto use that service. The following CLI changes are included that may break existing clients:ftl configandftl secretnow require a running controllerftl secret set <ref> --op=VAULTis no longer supportedftl-controllerandftl devaccept a 1Password vault using--opvault=VAULTftl secret set <ref> --opis supported, whereopis a bool flag that requires the controller to have an--opvault