Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert error on missing config as it breaks the integration tests #1504

Merged
merged 1 commit into from
May 16, 2024

Conversation

alecthomas
Copy link
Collaborator

@alecthomas alecthomas commented May 16, 2024

See https://github.com/TBD54566975/ftl/actions/runs/9102976431/job/25023813425

I'm going to pull the integration tests into PR CI, unfortunately it's really opaque when it only runs on main.

Revert "fix: error out if specified config doesn't exist, fixes #1347 (#1485)"

This reverts commit 57659f3.

@alecthomas alecthomas requested review from safeer, a team and wesbillman and removed request for a team May 16, 2024 02:43
@alecthomas alecthomas mentioned this pull request May 16, 2024
@alecthomas alecthomas enabled auto-merge (squash) May 16, 2024 02:44
@alecthomas alecthomas merged commit 1c12c8f into main May 16, 2024
11 checks passed
@alecthomas alecthomas deleted the aat/revert-config branch May 16, 2024 02:46
safeer added a commit that referenced this pull request May 16, 2024
safeer added a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI should error if --config or FTL_CONFIG specifies invalid files
1 participant