Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI should error if --config or FTL_CONFIG specifies invalid files #1347

Closed
alecthomas opened this issue Apr 28, 2024 · 0 comments · Fixed by #1504
Closed

CLI should error if --config or FTL_CONFIG specifies invalid files #1347

alecthomas opened this issue Apr 28, 2024 · 0 comments · Fixed by #1504
Assignees
@safeer
Labels
good first issue Good for newcomers

Comments

@alecthomas
Copy link
Collaborator

I think currently it will check for os.ErrNotExist and silently succeed, because that is the behaviour we want when trying to load the default config. It is not, however, the behaviour we want when loading explicitly specified config.
@alecthomas alecthomas added the good first issue Good for newcomers label Apr 28, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Apr 28, 2024
@alecthomas alecthomas mentioned this issue Apr 28, 2024
Open
@bradleydwyer bradleydwyer removed the triage Issue needs triaging label Apr 29, 2024
safeer pushed a commit that referenced this issue May 15, 2024
fix: error out if specified config doesn't exist, fixes #1347
6e6ff0a
@safeer safeer closed this as completed in 57659f3 May 15, 2024
alecthomas added a commit that referenced this issue May 16, 2024
@alecthomas
chore: revert error on missing config as it breaks the ingration tests
bcf5680 
See https://github.com/TBD54566975/ftl/actions/runs/9102976431/job/25023813425

Revert "fix: error out if specified config doesn't exist, fixes #1347 (#1485)"

This reverts commit 57659f3.
@alecthomas alecthomas mentioned this issue May 16, 2024
Merged
alecthomas added a commit that referenced this issue May 16, 2024
@alecthomas
chore: revert error on missing config as it breaks the integration te…
1c12c8f 
…sts (#1504)

See
https://github.com/TBD54566975/ftl/actions/runs/9102976431/job/25023813425

I'm going to pull the integration tests into PR CI, unfortunately it's
really opaque when it only runs on main.

Revert "fix: error out if specified config doesn't exist, fixes #1347
(#1485)"

This reverts commit 57659f3.
safeer added a commit that referenced this issue May 17, 2024
@safeer
fix: error out if cli config doesn't exist, fixes #1347 (#1517)
80c00ab 
This reverts commit 4a2902d
Integration tests now run successfully after #1514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safeer safeer

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: revert error on missing config as it breaks the integration tests block/ftl
3 participants
@alecthomas @bradleydwyer @safeer