This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed lint errors (and brought Time Picker coverage to 100%) #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
==========================================
- Coverage 99.94% 99.94% -0.01%
==========================================
Files 286 286
Lines 5092 5089 -3
Branches 596 594 -2
==========================================
- Hits 5089 5086 -3
Misses 3 3
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
changed the title
Closed
Blackbaud-PatrickOFriel
approved these changes
May 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this branch merged (and published) will allow the build to go through on the
ng4-upgradebranch.inlineFilterspublic:ERROR in /home/travis/build/blackbaud/skyux2/.skypagestmp/src/ngfactory/node_modules/@blackbaud/skyux/dist/modules/list-filters/list-filter-inline.component.ngfactory.ts (78,30): Property 'inlineFilters' is private and only accessible within class 'SkyListFilterInlineComponent'.activepublic:ERROR in /home/travis/build/blackbaud/skyux2/.skypagestmp/src/ngfactory/node_modules/@blackbaud/skyux/dist/modules/list-view-checklist/list-view-checklist.component.ngfactory.ts (285,77): Property 'active' is protected and only accessible within class 'ListViewComponent' and its subclasses.