This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Angular 4 Upgrade #704
Closed
Angular 4 Upgrade #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - fix search and sort tests
TODO: - fix code coverage gaps
* Allow for proper nesting for getting data for lists and grids (#671) * Changed the list helper getData function to set the result to null if the final part was undefined so that nesting works correctly. * Added unit tests * updates skyux2 docs to use stache2 (#681) * home page and pulling in stache things * removed need for title service * components demo component using stache * removed change to package json * removed unecessary method * updating learn page and removing overview folder * spacing issue fixed * Convert reference topics to Stache 2 * refactored all the tutorial section * Doc tweaks for Stache 2. * Final doc tweaks before merge * versioned without vs * Update builder version (#693) * Update builder version * Remove unneeded packages * Update full page modal header sizes (#679) * Update full page modal header sizes * Update full screen modal screenshots * Travis build 1313 pushed to skyux2 [ci skip] * Update wait component z-index (#684) * Travis build 1316 pushed to skyux2 [ci skip] * Adjust padding for closeable tab (#685) To account for built-in padding in the close button. * Travis build 1318 pushed to skyux2 [ci skip] * Handle styles for filedrop when links are not allowed (#686) * Travis build 1325 pushed to skyux2 [ci skip] * Add cancel button to wizard docs and update modal button spacing (#689) * Added yarn lock * Cleaned files based on lint rules * Removed unused comments * Updated excluded source maps * Updated version of tslint
package.json
Outdated
| "istanbul-instrumenter-loader": "0.1.0", | ||
| "jasmine": "2.5.2", | ||
| "@angular/compiler-cli": "4.1.2", | ||
| "@blackbaud/skyux-builder": "blackbaud/skyux-builder#update-angular", |
There was a problem hiding this comment.
We can point this to an actual version after Builder is upgraded.
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 99.94% 99.85% -0.09%
==========================================
Files 286 286
Lines 5151 4861 -290
Branches 603 623 +20
==========================================
- Hits 5148 4854 -294
- Misses 3 7 +4
Continue to review full report at Codecov.
|
Use browserstack service instead of binary. Also fix error with axe.
* Add start of visual tests * continue working on skyux builder visual tests * more work on getting builder visual tests to work * More work around visual tests * fix package name typo * Update import paths for visual test spa * Add normalize-scss to package.json * Fix moment import to work with rollup This way works also with copying the dist folder to node_modules * fix tile strangeness * start scripts for visual test setup * Continue protractor work * start of visual test command * duplicate a bit of work to get protractor ready to go * Get protractor to go to a page * Add first pass at image comparison TODO: - do not fail when image does not exist * Continue pixdiff work * Work on thresholds * Screenshots working with alert visual test TODO: - create compare screenshot wrapper function - get action button tests - get working with browserstack - get working with browserstack and TravisCI * Add wrapper function for visual tests TODO: - accessibility testing - more elegant way to change size - use browserstack - travis commands * Add checkAccessibility TODO: - browserstack configuration - get working in travis * Break out local visual test conf file * Add content for ci visual tests TODO: - switch configuration file used based on argue - test using browserstack - add the rest of the tests - get TravisCI implementations working * Allow visual tests to change config based on command line * Browserstack tests working * fix browserstack local visual tests TODO: - get other tests moved over - test using browserstack - get TravisCI integration working - remove all traces of wdio and old tests * Add avatar visual test * Add button visual test * Add visual tests for card, checkbox, and chevron * Add datepicker, definition list, and dropdown visual tests * Add error, file drop, and filter visual tests * Add visual tests for grid, key-info, label, list-secondary-actions, list-view-checklist, and modals * add visual tests for navbar * Add page summary visual tests * Add visual tests for paging, radio, repeater * Add visual tests for search, sort, tabs * Add visual tests for text-expand, text-expand-repeater, tiles * Finsih visual tests * Updated visual tests * Update ci tests * fix package.json conflict * update other visual test scripts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #549.
This branch requires #741 to be merged and published.