Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Contrib > Lookup Component (Part 2) > Autocomplete component #1438

Merged
merged 49 commits into from
Feb 8, 2018
Merged
Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
12f6e9e
Initial commit
Blackbaud-SteveBrush Jan 26, 2018
be041db
Merge branch 'master' into autocomplete
Blackbaud-SteveBrush Jan 26, 2018
c355a1b
Removed duplicate features
Blackbaud-SteveBrush Jan 26, 2018
dd639d5
Final cleanup
Blackbaud-SteveBrush Jan 26, 2018
5822e7b
Style changes
Blackbaud-SteveBrush Jan 26, 2018
1c9099d
Updated scss styles
Blackbaud-SteveBrush Jan 26, 2018
3eb43cf
Fixed linting error
bobbyearl Jan 27, 2018
393f0e9
Merge branch 'master' into autocomplete
Blackbaud-SteveBrush Jan 27, 2018
c5df627
Fixed default search function not working
Blackbaud-SteveBrush Jan 27, 2018
9e5eed6
Upgrading ux and builder
Blackbaud-SteveBrush Jan 27, 2018
d6d382e
Added a few unit tests
Blackbaud-SteveBrush Jan 28, 2018
356e65b
Minor implementation changes
Blackbaud-SteveBrush Jan 28, 2018
43ba9fb
Fixed click events not working
Blackbaud-SteveBrush Jan 29, 2018
e8b372d
Fixed strange popover bug where mouseleave was not triggered
Blackbaud-SteveBrush Jan 29, 2018
8ea8849
Full coverage, visual tests
Blackbaud-SteveBrush Jan 30, 2018
a1ef501
Fixed build issue with demo
Blackbaud-SteveBrush Jan 30, 2018
91e7fa0
Fixed race condition with item changes
Blackbaud-SteveBrush Jan 30, 2018
251e975
Removed fdescribe
Blackbaud-SteveBrush Jan 30, 2018
aaf2c73
Added check to prevent multiple calls to the popover open method
Blackbaud-SteveBrush Jan 30, 2018
03b9969
Fixed unit test
Blackbaud-SteveBrush Jan 30, 2018
f0a919a
Fixed dropdown positioning in grid and modal
Blackbaud-SteveBrush Jan 30, 2018
037a4ab
Removed box-shadow
Blackbaud-SteveBrush Jan 30, 2018
7ffa166
Removed focusin handler to accommodate mobile browsers
Blackbaud-SteveBrush Jan 31, 2018
8ff24a2
Fixed builder runtime warnings
Blackbaud-SteveBrush Jan 31, 2018
aa45f78
Merge branch 'master' into autocomplete
Blackbaud-SteveBrush Jan 31, 2018
843362f
Reverting changes
Blackbaud-SteveBrush Jan 31, 2018
a085b69
Using fixed position instead of absolute
Blackbaud-SteveBrush Jan 31, 2018
d63b4f9
Removed unused styles
Blackbaud-SteveBrush Jan 31, 2018
57ea855
Merge branch 'fix-dropdown-position' of https://github.com/blackbaud/…
Blackbaud-SteveBrush Jan 31, 2018
c1443c2
Fixed unit tests
Blackbaud-SteveBrush Jan 31, 2018
2533b92
Unit tests
Blackbaud-SteveBrush Feb 1, 2018
18147e4
Fixed visual tests
Blackbaud-SteveBrush Feb 1, 2018
4d19ba9
Removed comments
Blackbaud-SteveBrush Feb 1, 2018
30d07cb
Added visual test
Blackbaud-SteveBrush Feb 2, 2018
bf4de8a
Merged from fix
Blackbaud-SteveBrush Feb 2, 2018
5240bd6
Merge branch 'master' into fix-dropdown-position
Blackbaud-SteveBrush Feb 7, 2018
22c8c45
Removed debounce time
Blackbaud-SteveBrush Feb 7, 2018
6c4b9b0
Merge branch 'fix-dropdown-position' into autocomplete
Blackbaud-SteveBrush Feb 7, 2018
8133bc0
Removed commented out css
Blackbaud-SteveBrush Feb 7, 2018
804b329
Merged conflicts
Blackbaud-SteveBrush Feb 7, 2018
015d179
Merge branch 'master' into autocomplete
Blackbaud-SteveBrush Feb 7, 2018
d50b8bb
Updated text highlight to execute after content checked
Blackbaud-SteveBrush Feb 8, 2018
eafa4c4
Merge branch 'master' into autocomplete
Blackbaud-SteveBrush Feb 8, 2018
db34727
Removed debounce time for resize
Blackbaud-SteveBrush Feb 8, 2018
93f68f6
Updated ux version
Blackbaud-SteveBrush Feb 8, 2018
94a053b
Merge branch 'master' into autocomplete
Blackbaud-SteveBrush Feb 8, 2018
e6561a5
Added fix for list view grid demo search not working
Blackbaud-SteveBrush Feb 8, 2018
b23980c
Merge branch 'master' into autocomplete
Blackbaud-SteveBrush Feb 8, 2018
840d944
Updated styles
Blackbaud-SteveBrush Feb 8, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
"@angular/platform-browser": "4.3.6",
"@angular/platform-browser-dynamic": "4.3.6",
"@angular/router": "4.3.6",
"@blackbaud/skyux": "2.3.2",
"@blackbaud/skyux-builder": "1.7.1",
"@blackbaud/skyux": "2.8.0",
"@blackbaud/skyux-builder": "1.10.0",
"@blackbaud/skyux-design-tokens": "0.0.8",
"@types/core-js": "0.9.41",
"@types/jasmine": "2.5.47",
Expand Down
4 changes: 2 additions & 2 deletions skyux-spa-visual-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
"author": "Blackbaud",
"license": "ISC",
"devDependencies": {
"@blackbaud/skyux": "2.3.2",
"@blackbaud/skyux-builder": "1.6.2",
"@blackbaud/skyux": "2.8.0",
"@blackbaud/skyux-builder": "1.10.0",
"pix-diff": "2.0.0",
"browserstack-local": "1.3.0"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<div id="screenshot-autocomplete">
<label for="favorite-color">Favorite color</label>
<sky-autocomplete
[data]="data">
<input
id="favorite-color"
skyAutocomplete
type="text">
</sky-autocomplete>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import {
Component
} from '@angular/core';

@Component({
selector: 'autocomplete-visual',
templateUrl: './autocomplete-visual.component.html'
})
export class AutocompleteVisualComponent {
public data: any[] = [
{ name: 'Red' },
{ name: 'Blue' },
{ name: 'Green' },
{ name: 'Orange' },
{ name: 'Pink' },
{ name: 'Purple' },
{ name: 'Yellow' },
{ name: 'Brown' },
{ name: 'Turquoise' },
{ name: 'White' },
{ name: 'Black' }
];
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import {
browser,
by,
element
} from 'protractor';

import { SkyVisualTest } from '../../../config/utils/visual-test-commands';

describe('Autocomplete', () => {
it('should match previous alert screenshot', () => {
return SkyVisualTest
.setupTest('autocomplete')
.then(() => {
const input = element(by.css('input'));
input.value = 'r';
input.click();
browser.actions().sendKeys('r').perform();

browser.wait(() => {
return browser.isElementPresent(
element(by.css('.sky-dropdown-item'))
);
});

return SkyVisualTest.compareScreenshot({
screenshotName: 'autocomplete',
selector: '#screenshot-autocomplete'
});
});
});

it('should match previous alert screenshot on small screens', () => {
return SkyVisualTest
.setupTest('autocomplete', 480)
.then(() => {

const input = element(by.css('input'));
input.value = 'r';
input.click();
browser.actions().sendKeys('r').perform();

browser.wait(() => {
return browser.isElementPresent(
element(by.css('.sky-dropdown-item'))
);
});

return SkyVisualTest.compareScreenshot({
screenshotName: 'autocomplete',
selector: '#screenshot-autocomplete'
});
});
});
});
1 change: 1 addition & 0 deletions skyux-spa-visual-tests/src/app/autocomplete/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<autocomplete-visual></autocomplete-visual>
13 changes: 8 additions & 5 deletions src/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import { SKY_FLYOUT_PROVIDERS } from './modules/flyout';
import { SKY_MODAL_PROVIDERS } from './modules/modal';
import { SKY_WAIT_PROVIDERS } from './modules/wait';

import { SkyActionButtonModule } from './modules/action-button';
import { SkyAlertModule } from './modules/alert';
import { SkyNumericModule } from './modules/numeric';
import { SkyAvatarModule } from './modules/avatar';
import { SkyActionButtonModule } from './modules/action-button';
import { SkyAutocompleteModule } from './modules/autocomplete';
import { SkyCardModule } from './modules/card';
import { SkyCheckboxModule } from './modules/checkbox';
import { SkyChevronModule } from './modules/chevron';
Expand Down Expand Up @@ -48,6 +48,7 @@ import { SkyListViewGridModule } from './modules/list-view-grid';
import { SkyMediaQueryModule } from './modules/media-queries';
import { SkyModalModule } from './modules/modal';
import { SkyNavbarModule } from './modules/navbar';
import { SkyNumericModule } from './modules/numeric';
import { SkyPageSummaryModule } from './modules/page-summary';
import { SkyPagingModule } from './modules/paging';
import { SkyPopoverModule } from './modules/popover';
Expand All @@ -69,10 +70,10 @@ import { SkyWaitModule } from './modules/wait';

@NgModule({
exports: [
SkyActionButtonModule,
SkyAlertModule,
SkyNumericModule,
SkyAutocompleteModule,
SkyAvatarModule,
SkyActionButtonModule,
SkyCardModule,
SkyCheckboxModule,
SkyChevronModule,
Expand Down Expand Up @@ -104,6 +105,7 @@ import { SkyWaitModule } from './modules/wait';
SkyMediaQueryModule,
SkyModalModule,
SkyNavbarModule,
SkyNumericModule,
SkyPageSummaryModule,
SkyPagingModule,
SkyPopoverModule,
Expand All @@ -128,7 +130,7 @@ import { SkyWaitModule } from './modules/wait';
export class SkyModule { }

export * from './modules/alert';
export * from './modules/numeric';
export * from './modules/autocomplete';
export * from './modules/avatar';
export * from './modules/action-button';
export * from './modules/card';
Expand Down Expand Up @@ -164,6 +166,7 @@ export * from './modules/list-view-grid';
export * from './modules/modal';
export * from './modules/media-queries';
export * from './modules/navbar';
export * from './modules/numeric';
export * from './modules/page-summary';
export * from './modules/paging';
export * from './modules/popover';
Expand Down
22 changes: 18 additions & 4 deletions src/demo.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { FormsModule } from '@angular/forms';
import {
NgModule
} from '@angular/core';

import {
CommonModule
} from '@angular/common';

import { SkyModule } from './core';
import {
FormsModule,
ReactiveFormsModule
} from '@angular/forms';

import {
SkyModule
} from './core';

import {
SkyActionButtonDemoComponent,
SkyAlertDemoComponent,
SkyAutocompleteDemoComponent,
SkyAvatarDemoComponent,
SkyCardDemoComponent,
SkyCheckboxDemoComponent,
Expand Down Expand Up @@ -81,6 +93,7 @@ import {
const components = [
SkyActionButtonDemoComponent,
SkyAlertDemoComponent,
SkyAutocompleteDemoComponent,
SkyAvatarDemoComponent,
SkyCardDemoComponent,
SkyCheckboxDemoComponent,
Expand Down Expand Up @@ -154,6 +167,7 @@ const components = [
imports: [
CommonModule,
FormsModule,
ReactiveFormsModule,
SkyModule
],
exports: components,
Expand Down
Loading