Contrib > Lookup Component (Part 2) > Autocomplete component

[Blackbaud-SteveBrush]

Features/requirements:

• Should accept custom search function
• Should accept custom search filters
• Should accept custom search result template
• Should accept default value (an object of type any)
• Should accept array of object property names to search against
• Should accept number of minimum characters the user must type before a search is issued

Implementation pulled from original contribution by @Blackbaud-TomRamsey: #1220
Related, part 1: #1386

[codecov-io]

Codecov Report

Merging #1438 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #1438    +/-   ##
=======================================
  Coverage     100%    100%            
=======================================
  Files         378     382     +4     
  Lines        7146    7400   +254     
  Branches      908     946    +38     
=======================================
+ Hits         7146    7400   +254

Impacted Files	Coverage Δ
src/modules/dropdown/dropdown.component.ts	100% <100%> (ø)	⬆️
...tocomplete/autocomplete-default-search-function.ts	100% <100%> (ø)
src/modules/autocomplete/autocomplete.module.ts	100% <100%> (ø)
...dules/autocomplete/autocomplete-input.directive.ts	100% <100%> (ø)
src/modules/autocomplete/autocomplete.component.ts	100% <100%> (ø)
...rc/modules/dropdown/types/dropdown-message-type.ts	100% <100%> (ø)	⬆️
...modules/text-highlight/text-highlight.directive.ts	100% <100%> (ø)	⬆️
src/modules/dropdown/dropdown-menu.component.ts	100% <100%> (ø)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2def0f3...840d944. Read the comment docs.

[Blackbaud-BobbyEarl]

This LGTM. Only one small thing I noticed, the search highlighting seemed a little off. For most mast cases, it didn't always highlight matches.

[Blackbaud-BobbyEarl]

LGTM. Non-blocking feedback. I would remove the alerts, but keep the text from the demo component.