Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes in documentation #17

Merged
merged 1 commit into from Jun 1, 2021
Merged

minor fixes in documentation #17

merged 1 commit into from Jun 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2021

There were some unnatural grammar usage in the documentation and the name of this project is incorrectly displayed at the end of it(It's displayed as Proton Fix, which is the old name) .
I suggest you to change the directory tree of this repo to be easier to install this theme. (What I mean by that is to move the .css files and /icons folder to a new directory called chrome.)

@black7375 black7375 merged commit 5f0053d into black7375:master Jun 1, 2021
@black7375
Copy link
Owner

black7375 commented Jun 1, 2021

Thanks for the contribution.

I suggest you to change the directory tree of this repo to be easier to install this theme. (What I mean by that is to move the .css files and /icons folder to a new directory called chrome.)

Changing file position is a breaking change.
I expect those who are familiar with git will be installing git clone https://github.com/black7375/Firefox-UI-Fix.git chrome and updating to git pull.

I don't want to break their workflow.
Instead, we are considering installing via script.
It is a method to cloning or unzip to a folder called chrome, and then install it using install.sh[Linux, Mac] or install.ps1[Windows] script.

@black7375 black7375 mentioned this pull request Jun 1, 2021
@ghost
Copy link
Author

ghost commented Jun 1, 2021

I have considered that too. Maybe I could help you on making that script.

@ghost
Copy link
Author

ghost commented Jun 1, 2021

Maybe submitting the .ps1 installation file to Chocolatey is a good idea.

@black7375
Copy link
Owner

black7375 commented Jun 1, 2021

Maybe submitting the .ps1 installation file to Chocolatey is a good idea.

LGTM 👍
But when a user has multiple profiles, it can become a little complicated.
First we need to make it a local target.

@ghost
Copy link
Author

ghost commented Jun 1, 2021

Pasting the files in every profile folder could be a quick and dirty solution to what you said.

@black7375
Copy link
Owner

In general, I think we shouldn't perform side effects that users don't expect.

Instead, we can try to modify the name of the directory where the script is located.

@black7375
Copy link
Owner

Then, just unzip the directory by directory and run the script and you are done.

@black7375 black7375 added the Issue::Documentation Improvements or additions to documentation label Jun 1, 2021
@ghost
Copy link
Author

ghost commented Jun 1, 2021

I'll try working on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant