Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider an installation that would allow git pulling for new changes and allow you to keep custom additions #87

Closed
travisnewman opened this issue Jun 11, 2021 · 9 comments
Labels
Install Problems in the installation process Issue::Documentation Improvements or additions to documentation

Comments

@travisnewman
Copy link

travisnewman commented Jun 11, 2021

A problem with the installation method is that you need to re-download each time and if you've made custom changes they will get overwritten when copying the new usercrhome.

Using imports you can keep multiple styles that are easily swappable, easily upgradable, and you can keep your custom styles between all of them.

For example, please see how this project works:
https://github.com/ideaweb/firefox-safari-style

@ctrlcmdshft
Copy link

This would be a great to make updating much easier

@ghost
Copy link

ghost commented Jun 12, 2021

The installer script on the master branch is just a pseudoscript and does practically nothing. I’m currently working on the installer script and I’ll consider adding a pull option.

@black7375 black7375 added Issue::Documentation Improvements or additions to documentation Install Problems in the installation process labels Jun 12, 2021
@black7375
Copy link
Owner

#17 (comment)

I also update with git pull, and people who have used git often are probably doing that.
This is why I keep the current file structure.

By the time the 2.0 version comes out, there will be 3 installation guides.

  • Manual Install: current guide
  • Release Install: using the official release
  • Install for Developers: using git clone & git pull

@ghost
Copy link

ghost commented Jun 12, 2021

@black7375 I think the install.sh could cover the manual and release installation methods. Most people just want to get a UI fix, not a painstaking handcopy installation That could crαp itself when improperly copied.

@black7375
Copy link
Owner

Yes, that's right.

@ghost ghost mentioned this issue Jun 12, 2021
3 tasks
@travisnewman
Copy link
Author

This all sounds great, thanks! :)

@ghost ghost mentioned this issue Jun 14, 2021
@ghost
Copy link

ghost commented Jun 14, 2021

partially included in #93

@black7375
Copy link
Owner

I think it has been solved through v5.0.0's script.

  • If there are any changes: Run git stash and git stash pop before and after git pull.
  • If there are user-overrides.js, userChrome-overrides.css, and userContent-overrides.css files, proceed with override

@bb010g
Copy link
Contributor

bb010g commented May 2, 2022

I use symbolic links to a repository checkout, and the new v5 layout would be even smoother if the new css directory containing leptonChrome.css and leptonContent.css was named leptonCss or similar, so as to not conflict with any other CSS subdirectories in $FIREFOX_PROFILE/chrome/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Install Problems in the installation process Issue::Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants