Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5313] Upgrade to SQL Server 2022 #3580

Merged
merged 5 commits into from
Feb 2, 2024
Merged

[PM-5313] Upgrade to SQL Server 2022 #3580

merged 5 commits into from
Feb 2, 2024

Conversation

withinfocus
Copy link
Contributor

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Moves from 2019 to 2022 and enables us to use new language features in scripts and the cloud.

Code changes

  • util/MsSql/Dockerfile: Base image change.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@withinfocus
Copy link
Contributor Author

Relates to #3548.

@withinfocus withinfocus marked this pull request as ready for review December 14, 2023 22:23
@withinfocus withinfocus requested a review from a team as a code owner December 14, 2023 22:23
@withinfocus withinfocus requested a review from a team December 14, 2023 22:23
rkac-bw
rkac-bw previously approved these changes Dec 15, 2023
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@withinfocus withinfocus changed the title Upgrade to SQL Server 2022 [PM-5313] Upgrade to SQL Server 2022 Dec 15, 2023
vgrassia
vgrassia previously approved these changes Dec 18, 2023
@withinfocus withinfocus dismissed stale reviews from vgrassia and rkac-bw via d8e2d1a February 1, 2024 17:20
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 1, 2024

Logo
Checkmarx One – Scan Summary & Details945f15dd-ec61-42fe-abad-3be19712961b

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7 When installing a package, its pin version should be defined
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7 When installing a package, its pin version should be defined
LOW Multiple RUN, ADD, COPY, Instructions Listed /Dockerfile: 13 Multiple commands (RUN, COPY, ADD) should be grouped in order to reduce the number of layers.

Fixed Issues

Severity Issue Source File / Package
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7
LOW Multiple RUN, ADD, COPY, Instructions Listed /Dockerfile: 13

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b20b809) 39.28% compared to head (bc50719) 39.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3580   +/-   ##
=======================================
  Coverage   39.28%   39.28%           
=======================================
  Files        1036     1036           
  Lines       51263    51263           
  Branches     4592     4592           
=======================================
  Hits        20138    20138           
+ Misses      30177    30176    -1     
- Partials      948      949    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rkac-bw
rkac-bw previously approved these changes Feb 1, 2024
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@withinfocus withinfocus dismissed rkac-bw’s stale review February 2, 2024 13:58

The merge-base changed after approval.

Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@withinfocus withinfocus requested a review from a team February 2, 2024 14:15
@withinfocus withinfocus merged commit 472b1f8 into main Feb 2, 2024
46 of 47 checks passed
@withinfocus withinfocus deleted the sql2022 branch February 2, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants