Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5314] Upgrade MSSQL cumulative update #3548

Merged
merged 4 commits into from
Feb 2, 2024
Merged

[PM-5314] Upgrade MSSQL cumulative update #3548

merged 4 commits into from
Feb 2, 2024

Conversation

withinfocus
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Utilizes a new cumulative update for SQL Server 2019.

Code changes

  • util/MsSql/Dockerfile: Base image change.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@withinfocus withinfocus marked this pull request as ready for review December 11, 2023 21:13
@withinfocus withinfocus requested a review from a team as a code owner December 11, 2023 21:13
@bitwarden-bot
Copy link

bitwarden-bot commented Dec 12, 2023

Logo
Checkmarx One – Scan Summary & Details6f51627f-a7ce-4365-b76f-ade9021300ec

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7 When installing a package, its pin version should be defined
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7 When installing a package, its pin version should be defined
LOW Multiple RUN, ADD, COPY, Instructions Listed /Dockerfile: 13 Multiple commands (RUN, COPY, ADD) should be grouped in order to reduce the number of layers.

Fixed Issues

Severity Issue Source File / Package
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7
MEDIUM Apt Get Install Pin Version Not Defined /Dockerfile: 7
LOW Multiple RUN, ADD, COPY, Instructions Listed /Dockerfile: 13

rkac-bw
rkac-bw previously approved these changes Dec 15, 2023
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@withinfocus withinfocus changed the title Upgrade MSSQL cumulative update [PM-5314] Upgrade MSSQL cumulative update Dec 15, 2023
vgrassia
vgrassia previously approved these changes Dec 18, 2023
@withinfocus withinfocus dismissed stale reviews from vgrassia and rkac-bw via 97dd88b January 5, 2024 20:04
@withinfocus withinfocus requested a review from rkac-bw February 1, 2024 22:29
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@withinfocus withinfocus requested a review from a team February 2, 2024 13:36
@withinfocus withinfocus merged commit b20b809 into main Feb 2, 2024
40 of 41 checks passed
@withinfocus withinfocus deleted the sqlupgrade branch February 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants