Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-1497] Known device api error #2418

Merged
merged 4 commits into from
Mar 17, 2023
Merged

[PM-1497] Known device api error #2418

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3357a1e
[PM-1497] Ignore know device api error.
andrebispo5 Mar 16, 2023
1051e9b
[PM-1497] Code format
andrebispo5 Mar 17, 2023
7b6ed73
Merge branch 'master' into bugfix/pm-1497-fail-known-device
andrebispo5 Mar 17, 2023
111d4a8
[PM-1497] refactor
andrebispo5 Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/App/Pages/Accounts/LoginPageViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,15 +150,21 @@ public async Task InitAsync()
{
Email = await _stateService.GetRememberedEmailAsync();
}
var deviceIdentifier = await _appIdService.GetAppIdAsync();
IsKnownDevice = await _apiService.GetKnownDeviceAsync(Email, deviceIdentifier);
CanRemoveAccount = await _stateService.GetActiveUserEmailAsync() != Email;
await _deviceActionService.HideLoadingAsync();
IsKnownDevice = await _apiService.GetKnownDeviceAsync(Email, await _appIdService.GetAppIdAsync());
}
catch (ApiException apiEx) when (apiEx.Error.StatusCode == System.Net.HttpStatusCode.Unauthorized)
{
_logger.Exception(apiEx);
}
catch (Exception ex)
{
HandleException(ex);
}
finally
{
await _deviceActionService.HideLoadingAsync();
}
}

public async Task LogInAsync(bool showLoading = true, bool checkForExistingAccount = false)
Expand Down