Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-1497] Known device api error #2418

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Conversation

andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Ignore Know Device api endpoint error on mobile.

Code changes

  • Check for api 401 error and silently log the exception instead of showing an error dialog
  • Moved the hide loading to finally block.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested a review from fedemkr March 17, 2023 13:16
@andrebispo5 andrebispo5 requested a review from fedemkr March 17, 2023 14:35
@andrebispo5 andrebispo5 merged commit a6bb089 into master Mar 17, 2023
@andrebispo5 andrebispo5 deleted the bugfix/pm-1497-fail-known-device branch March 17, 2023 15:07
andrebispo5 added a commit that referenced this pull request Mar 17, 2023
* [PM-1497] Ignore know device api error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants