Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14579] Backport to main #1126

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[PM-14579] Backport to main #1126

merged 2 commits into from
Nov 12, 2024

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Nov 11, 2024

🎟️ Tracking

PM-14579

📔 Objective

Backport #1121 to main

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6eeb2036-f6c7-40f7-8147-8740526b4f3f

No New Or Fixed Issues Found

@phil-livefront
Copy link
Collaborator

phil-livefront commented Nov 11, 2024

Hey @fedemkr, I don't see this PR in this backport. Should this include all of the tickets in the release branch or should I make a PR to include that into main? Sorry if that's a silly question, just want to make sure I didn't drop the ball on that. Thanks!

Ah i see this is only for PM-14579. Not sure how I missed that! I will make a PR to backport PM-14501 into main as well.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (4789311) to head (3582624).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...Shared/Core/Auth/Repositories/AuthRepository.swift 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   89.42%   89.44%   +0.01%     
==========================================
  Files         679      679              
  Lines       43082    43115      +33     
==========================================
+ Hits        38528    38564      +36     
+ Misses       4554     4551       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedemkr fedemkr merged commit c89573d into main Nov 12, 2024
9 checks passed
@fedemkr fedemkr deleted the PM-14579/backport-2024.11-rc1 branch November 12, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants