PM-14501 - Sometimes tapping the Verify Email link will not load the Master Password bottom sheet correctly

[phil-livefront]

🎟️ Tracking

PM-14501

📔 Objective

• This PR addresses an issue where setting DebugMenuCoordinator as a child coordinator within AuthCoordinator caused a navigation error during the email verification flow. Specifically, attempting to present CompleteRegistrationView resulted in the error:
  Attempt to present <UINavigationController: 0x1069ea200> on <UINavigationController: 0x10d010000> (from <UINavigationController: 0x10d010000>) whose view is not in the window hierarchy.
• The solution was to avoid setting DebugMenuCoordinator as a child coordinator, as it didn’t require being a part of the AuthCoordinator's child coordinators. This fix ensures that the email verification flow functions correctly without interference from the debug menu.

📸 Screenshots

##Before

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-07.at.16.48.09.mp4

##After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-07.at.16.48.56.mp4

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (5768168) to head (3028dbd).
Report is 1 commits behind head on release/2024.11-rc1.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           release/2024.11-rc1    #1118      +/-   ##
=======================================================
- Coverage                89.42%   89.41%   -0.01%     
=======================================================
  Files                      679      679              
  Lines                    43035    43034       -1     
=======================================================
- Hits                     38482    38481       -1     
  Misses                    4553     4553              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 9261abe6-a800-455e-b066-dfb0513971f1

No New Or Fixed Issues Found