Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16719] [COMMUNITY] Debounce requestIdleCallback a single time every 100ms, as opposed to call requestIdleCallback on debounce method #12695

Merged
merged 5 commits into from
Jan 16, 2025
Merged

[PM-16719] [COMMUNITY] Debounce requestIdleCallback a single time every 100ms, as opposed to call requestIdleCallback on debounce method #12695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff54bb4
[COMMUNITY] Debounce requestIdleCallback a single time every 100ms, a…
cagonzalezcs Jan 5, 2025
b13c97c
[COMMUNITY] Fixing broken jest mock of the debounce utils method
cagonzalezcs Jan 16, 2025
9551a67
Merge branch 'main' into patch-1
cagonzalezcs Jan 16, 2025
cf2fbdf
[COMMUNITY] Fixing broken jest mock of the debounce utils method
cagonzalezcs Jan 16, 2025
bc28fef
[COMMUNITY] Fixing broken jest mock of the debounce utils method
cagonzalezcs Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jest.mock("../utils", () => {
const utils = jest.requireActual("../utils");
return {
...utils,
debounce: jest.fn((fn) => fn),
debounce: jest.fn((fn, wait) => setTimeout(() => fn(), wait)),
};
});

Expand Down
6 changes: 4 additions & 2 deletions apps/browser/src/autofill/services/collect-autofill-content.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,8 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
}

if (!this.mutationsQueue.length) {
requestIdleCallbackPolyfill(debounce(this.processMutations, 100), { timeout: 500 });
// Collect all mutations and debounce the processing of those mutations by 100ms to ensure we don't process too many mutations at once.
debounce(this.processMutations, 100);
}
this.mutationsQueue.push(mutations);
};
Expand Down Expand Up @@ -982,7 +983,8 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
const queueLength = this.mutationsQueue.length;

if (!this.domQueryService.pageContainsShadowDomElements()) {
this.checkPageContainsShadowDom();
// Checking if a page contains shadowDOM elements is a heavy operation and doesn't have to be done immediately, so we can call this within an idle moment on the event loop.
requestIdleCallbackPolyfill(this.checkPageContainsShadowDom, { timeout: 500 });
}

for (let queueIndex = 0; queueIndex < queueLength; queueIndex++) {
Expand Down
Loading