[PM-16719] [COMMUNITY] Debounce requestIdleCallback a single time every 100ms, as opposed to call requestIdleCallback on debounce method #12695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
1 task
jprusik
previously approved these changes
Jan 6, 2025
|
Hey @cagonzalezcs , thanks for taking this on! Based on the linked issue, I think this makes sense at the code-level. I want to do some testing before we move it forward, but will report back here once that's completed. |
…s opposed to call requestIdleCallback on debounce method Potential fix for bitwarden#12031
|
A note; I rebased the branch since the basis was quite old.
edit: Looks like I was premature; there are some failing unit tests that need to be fixed. I have to put this down for now, but will come back to it. |
|
Fixed Issues (173)Great job! The following issues were fixed in this Pull Request
|
|
@jprusik I'll take some time later today to fix the tests. I think I know exactly why they're breaking. |
|
@jprusik Give it a shot now, I've updated the mocked |
jprusik
approved these changes
Jan 16, 2025
|
These changes have passed QA and have been merged; thanks so much for your work on this, @cagonzalezcs ! The updated code will go out with the next browser extension release |
|
It looks like these changes fail our BIT testing for cases where the inputs are not initially available (e.g. |
|
Shoot, sorry about that... hmm... without digging into it, I can't think of why it wouldn't capture the mutation... I'll see if I can take a quick look at some point this week. |
No worries at all; I've put together a PR for a partial revert for now, which restores to original autofill/inline menu behaviours that were lost: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #12031
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes