-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-10617 + PM-11270 fixes after QA review #3944
Changes from 2 commits
32f1c73
f0a5fe6
5ffa31e
276a6ec
def1079
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -170,7 +170,7 @@ private fun SetPasswordScreenContent( | |
Spacer(modifier = Modifier.height(16.dp)) | ||
|
||
BitwardenTextField( | ||
label = stringResource(id = R.string.master_password_hint), | ||
label = stringResource(id = R.string.master_password_hint_optional), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why change the name? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm, I see why you did it now. @SaintPatrck is this going to confuse Crowdin? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can make the new one "m_p_h_not_optional" haha There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not_specified * There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that would work There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I see you reverted renaming that resource so it's moot now, but for future reference, renaming will result in loss of existing translations for the resource being renamed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, thanks @SaintPatrck |
||
value = state.passwordHintInput, | ||
onValueChange = onPasswordHintInputChanged, | ||
hint = stringResource(id = R.string.master_password_hint_description), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do this instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making this change throughout the file for similar places