PM-10617 + PM-11270 fixes after QA review #3944
Conversation
|
No New Or Fixed Issues Found |
| @@ -170,7 +170,7 @@ private fun SetPasswordScreenContent( | |||
| Spacer(modifier = Modifier.height(16.dp)) | |||
|
|
|||
| BitwardenTextField( | |||
| label = stringResource(id = R.string.master_password_hint), | |||
| label = stringResource(id = R.string.master_password_hint_optional), | |||
There was a problem hiding this comment.
Why change the name?
There was a problem hiding this comment.
Hmmm, I see why you did it now.
@SaintPatrck is this going to confuse Crowdin?
There was a problem hiding this comment.
I can make the new one "m_p_h_not_optional" haha
There was a problem hiding this comment.
not_specified *
There was a problem hiding this comment.
I think that would work
There was a problem hiding this comment.
Hmmm, I see why you did it now.
@SaintPatrck is this going to confuse Crowdin?
I see you reverted renaming that resource so it's moot now, but for future reference, renaming will result in loss of existing translations for the resource being renamed.
There was a problem hiding this comment.
OK, thanks @SaintPatrck
| label = stringResource(id = R.string.master_password), | ||
| label = stringResource(id = R.string.master_password_required) | ||
| .takeIf { showNewOnboardingUi } | ||
| ?: stringResource(id = R.string.master_password), |
There was a problem hiding this comment.
Could we do this instead?
label = stringResource(
id = R.string.master_password_required
.takeIf { showNewOnboardingUi }
?: R.string.master_password,
)There was a problem hiding this comment.
making this change throughout the file for similar places
| }, | ||
| title = stringResource(id = R.string.create_account | ||
| .takeIf { state.onboardingEnabled } | ||
| ?: R.string.set_password), |
There was a problem hiding this comment.
Formatting:
stringResource(
id = R.string.create_account
.takeIf { state.onboardingEnabled }
?: R.string.set_password,
),
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3944 +/- ##
=======================================
Coverage 88.84% 88.85%
=======================================
Files 425 425
Lines 34885 34895 +10
Branches 5096 5105 +9
=======================================
+ Hits 30995 31005 +10
Misses 2110 2110
Partials 1780 1780 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10617
https://bitwarden.atlassian.net/browse/PM-11270
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes