Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-10630 setup autofill UI and interactions set up #3891

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

dseverns-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10630

📔 Objective

  • Setup Auto-Fill screen UI set and ready to be integrated with the new Onboarding flow
  • VM functions setup
  • Dialogs in place

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dseverns-livefront
Copy link
Collaborator Author

NOTES
90% of work for PM-10631 is in here (turn on later dialog). Will have separate PR once this is merged and #3878 merged.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Logo
Checkmarx One – Scan Summary & Details0fe5e4a8-f8e5-4e67-80a8-9dbd3dd6ab8d

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 97.07602% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.67%. Comparing base (b7544ef) to head (a37508d).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...i/auth/feature/accountsetup/SetupAutofillScreen.kt 96.00% 2 Missing and 2 partials ⚠️
...ture/accountsetup/handlers/SetupAutoFillHandler.kt 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3891      +/-   ##
==========================================
+ Coverage   88.62%   88.67%   +0.04%     
==========================================
  Files         409      412       +3     
  Lines       33744    33915     +171     
  Branches     4986     5001      +15     
==========================================
+ Hits        29907    30073     +166     
- Misses       2083     2085       +2     
- Partials     1754     1757       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dseverns-livefront dseverns-livefront merged commit 8dce8cd into main Sep 10, 2024
9 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-10630/autofill-onboarding-screen branch September 10, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants