PM-11464 Add onboarding status to user Account to allow for root navigation to onboarding flow. #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseverns-livefront
requested review from
SaintPatrck,
david-livefront and
brian-livefront
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3878 +/- ##
==========================================
- Coverage 88.69% 88.66% -0.04%
==========================================
Files 418 418
Lines 34051 34097 +46
Branches 5024 5038 +14
==========================================
+ Hits 30202 30232 +30
- Misses 2090 2097 +7
- Partials 1759 1768 +9 ☔ View full report in Codecov by Sentry. |
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt
Outdated
Show resolved
Hide resolved
dseverns-livefront
force-pushed
the
PM-11464/onboarding-status
branch
from
83d81e0
to
88a1bfd
Compare
|
with new changes hmmmdkfjdl.mp4 |
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensions.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/onboarding/OnboardingNavigation.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/model/OnboardingStatus.kt
Outdated
Show resolved
Hide resolved
dseverns-livefront
force-pushed
the
PM-11464/onboarding-status
branch
from
ccee0c9
to
99a3a8a
Compare
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensions.kt
Show resolved
Hide resolved
… root nav for onboarding flow optimize after rebase fix tests change root nav state to match reqs fix base route update where to set default value and other pr feedback Move to observe the onboaridng status per user and add autofill to navigation kdoc add tests cant always trust a test
dseverns-livefront
force-pushed
the
PM-11464/onboarding-status
branch
from
9f612da
to
00de217
Compare
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensions.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensions.kt
Show resolved
Hide resolved
| @@ -72,11 +72,12 @@ class SetupAutoFillViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| private fun handleTurnOnLaterConfirmClick() { | |||
| sendEvent(SetupAutoFillEvent.NavigateToCompleteSetup) | |||
| // TODO PM-10631 record user chose to turn on later for settings badging. | |||
| // TODO PM-10632 update status to complete setup step. | |||
There was a problem hiding this comment.
So we ditched the event and now we just need to update the state and then state-based nav just does the navigation for us?
There was a problem hiding this comment.
yes! We will need to add another onboarding status for "FINISH_SETUP" for navigating to the final confirm screen, but yeah none of the onboarding will need event navigation. When we complete the user state will update then the root nav state will be "VaultUnlocked"
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt
Outdated
Show resolved
Hide resolved
david-livefront
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11464
📔 Objective
OnboardingFlowfeature flag is on, set an onboarding status for the user📸 Screenshots
Control (onboarding off)
noonboading.mp4
onboarding on when account created
yesonboarding.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes