Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uart1 and Uart2 are broken due to initialization without baudrate. #405

Closed
AlexisTM opened this issue Mar 13, 2019 · 3 comments
Closed

Uart1 and Uart2 are broken due to initialization without baudrate. #405

AlexisTM opened this issue Mar 13, 2019 · 3 comments
Milestone

Comments

@AlexisTM
Copy link

Adding CFLAGS += -DENABLE_UART2 (or UART1) will break the software as the uartInit functions are called without the baudrate specified which is required for the function call.

void uart2Init(const uint32_t baudrate)

#ifdef ENABLE_UART1
uart1Init();
#endif
#ifdef ENABLE_UART2
uart2Init();
#endif

@krichardsson
Copy link
Contributor

Seems as the uart init functions were modified at some point to support baudrate, but the calls in the ifdefs were not.
When fixed, ENABLE_UART1 and ENABLE_UART2 should be added to the .travis.yml file to avoid similar problems in the future.

@AlexisTM
Copy link
Author

AlexisTM commented Mar 15, 2019

I guess the default of UART1 is 9600 (available in uart1.h) and I would propose uart2 to be 115200 by default (It is the roadrunner uart -green screw plug-)

krichardsson added a commit that referenced this issue Mar 15, 2019
@krichardsson
Copy link
Contributor

Fixed!

@krichardsson krichardsson added this to the next-release milestone Mar 19, 2019
cafeciaojoe pushed a commit to cafeciaojoe/crazyflie-firmware that referenced this issue Sep 27, 2024
Improved log-config functionality regarding bitcraze#405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants