-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bdk_hwi): remove bdk_hwi
, as HWISigner
's being moved to rust-hwi
#1561
refactor(bdk_hwi): remove bdk_hwi
, as HWISigner
's being moved to rust-hwi
#1561
Conversation
bdk_hwi
, as HWISigner
's being moved to rust-hwi
9570ca6
to
4ddc6ba
Compare
4ddc6ba
to
0708329
Compare
bitcoindevkit/rust-hwi#104 is merged. |
It seems this file was left out on the previous migration from hardware signers from `bdk_wallet` crate to the `bdk_hwi`, but it should've been removed.
94195dc
to
687ace9
Compare
- removes `bdk_hwi` crate, as `HWISigner`'s being moved to rust-hwi. - please refer to: bitcoindevkit/rust-hwi#104
687ace9
to
75c97a6
Compare
I rebased this PR and removed the |
Thanks! I just noticed that I forgot to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK cd8ddfe
fixes #1516
depends on bitcoindevkit/rust-hwi#104
Description
This PR removed the
bdk_hwi
crate, and the danglinghardwaresigner.rs
file frombdk_wallet
crate.It simplifies the BDK project workspace as it removes the dependency on
rust-hwi
, pyo3 and some required steps on CI.The removal is fine, as the
HWISigner
is being moved torust-hwi
project instead, please check: bitcoindevkit/rust-hwi#104Notes to the reviewers
Please let me know what you think about the removal, and if I missed anything.
Changelog notice
hardwaresigner.rs
file frombdk_wallet
crate.bdk_hwi
crate, moved torust-hwi
project.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: