Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bdk_hwi): remove bdk_hwi, as HWISigner's being moved to rust-hwi #1561

Merged

Conversation

oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented Aug 16, 2024

fixes #1516
depends on bitcoindevkit/rust-hwi#104

Description

This PR removed the bdk_hwi crate, and the dangling hardwaresigner.rs file from bdk_wallet crate.

It simplifies the BDK project workspace as it removes the dependency on rust-hwi, pyo3 and some required steps on CI.

The removal is fine, as the HWISigner is being moved to rust-hwi project instead, please check: bitcoindevkit/rust-hwi#104

Notes to the reviewers

Please let me know what you think about the removal, and if I missed anything.

Changelog notice

  • Removed dangling unused hardwaresigner.rs file from bdk_wallet crate.
  • Removed bdk_hwi crate, moved to rust-hwi project.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@oleonardolima oleonardolima changed the title Refactor/remove bdk hwi refactor(bdk_hwi): remove bdk_hwi, as HWISigner's being moved to rust-hwi Aug 16, 2024
@oleonardolima oleonardolima force-pushed the refactor/remove-bdk-hwi branch from 9570ca6 to 4ddc6ba Compare August 16, 2024 01:10
@oleonardolima oleonardolima marked this pull request as ready for review August 16, 2024 14:50
@nondiremanuel nondiremanuel added this to the 1.0.0-beta milestone Aug 20, 2024
@notmandatory notmandatory added api A breaking API change chore labels Aug 22, 2024
@oleonardolima oleonardolima force-pushed the refactor/remove-bdk-hwi branch from 4ddc6ba to 0708329 Compare August 26, 2024 18:27
@notmandatory
Copy link
Member

bitcoindevkit/rust-hwi#104 is merged.

It seems this file was left out on the previous migration from hardware
signers from `bdk_wallet` crate to the `bdk_hwi`, but it should've been
removed.
@notmandatory notmandatory force-pushed the refactor/remove-bdk-hwi branch from 94195dc to 687ace9 Compare September 11, 2024 14:45
@notmandatory notmandatory force-pushed the refactor/remove-bdk-hwi branch from 687ace9 to 75c97a6 Compare September 11, 2024 14:48
@notmandatory
Copy link
Member

I rebased this PR and removed the hwi/Cargo.toml file which looks like it was missed.

@oleonardolima
Copy link
Contributor Author

I rebased this PR and removed the hwi/Cargo.toml file which looks like it was missed.

Thanks! I just noticed that I forgot to remove the automation.json file used by the simulator, I removed it in cd8ddfe

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cd8ddfe

@notmandatory notmandatory merged commit 9020f44 into bitcoindevkit:master Sep 11, 2024
21 checks passed
@oleonardolima oleonardolima deleted the refactor/remove-bdk-hwi branch September 11, 2024 21:35
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A breaking API change chore
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move bdk_hwi to hwi module
3 participants