Skip to content

Commit

Permalink
Merge #1561: refactor(bdk_hwi): remove bdk_hwi, as HWISigner's be…
Browse files Browse the repository at this point in the history
…ing moved to `rust-hwi`

cd8ddfe chore: remove `ci/automation.json` file, used by Dockerfile.ledger (Leonardo Lima)
75c97a6 fix(ci)!: remove `Dockerfile.ledger` and `hwi` steps from coverage step (Leonardo Lima)
b118b82 refactor(bdk_hwi)!: remove `bdk_hwi` (Leonardo Lima)
43257cf refactor(wallet)!: remove dangling unused `hardwaresigner.rs` file (Leonardo Lima)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->
  fixes #1516
  depends on bitcoindevkit/rust-hwi#104

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  This PR removed the `bdk_hwi` crate, and the dangling `hardwaresigner.rs` file from `bdk_wallet` crate.

  It simplifies the BDK project workspace as it removes the dependency on `rust-hwi`, pyo3 and some required steps on CI.

  The removal is fine, as the `HWISigner` is being moved to `rust-hwi` project instead, please check: bitcoindevkit/rust-hwi#104

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  Please let me know what you think about the removal, and if I missed anything.

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  - Removed dangling unused `hardwaresigner.rs` file from `bdk_wallet` crate.
  - Removed `bdk_hwi` crate, moved to `rust-hwi` project.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK cd8ddfe

Tree-SHA512: 43fe716a3f107ae806b1c9bf83bd0a9f403d3c331443d78c9c4c55ac995577fd8b02ba13b77bbadb72b329e0fc94c22a7a9c8b2478ecad303d2c8db28393da2d
  • Loading branch information
notmandatory committed Sep 11, 2024
2 parents a4b4946 + cd8ddfe commit 9020f44
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 297 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/code_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,6 @@ jobs:
uses: Swatinem/[email protected]
- name: Install grcov
run: if [[ ! -e ~/.cargo/bin/grcov ]]; then cargo install grcov; fi
# TODO: re-enable the hwi tests
- name: Build simulator image
run: docker build -t hwi/ledger_emulator ./ci -f ci/Dockerfile.ledger
- name: Run simulator image
run: docker run --name simulator --network=host hwi/ledger_emulator &
- name: Install Python
uses: actions/setup-python@v4
with:
python-version: '3.9'
- name: Install python dependencies
run: pip install hwi==2.1.1 protobuf==3.20.1
- name: Test
run: cargo test --all-features
- name: Make coverage directory
Expand Down
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ members = [
"crates/electrum",
"crates/esplora",
"crates/bitcoind_rpc",
"crates/hwi",
"crates/testenv",
"example-crates/example_cli",
"example-crates/example_electrum",
Expand Down
9 changes: 0 additions & 9 deletions ci/Dockerfile.ledger

This file was deleted.

30 changes: 0 additions & 30 deletions ci/automation.json

This file was deleted.

16 changes: 0 additions & 16 deletions crates/hwi/Cargo.toml

This file was deleted.

3 changes: 0 additions & 3 deletions crates/hwi/README.md

This file was deleted.

39 changes: 0 additions & 39 deletions crates/hwi/src/lib.rs

This file was deleted.

94 changes: 0 additions & 94 deletions crates/hwi/src/signer.rs

This file was deleted.

94 changes: 0 additions & 94 deletions crates/wallet/src/wallet/hardwaresigner.rs

This file was deleted.

0 comments on commit 9020f44

Please sign in to comment.