Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin home dependency to 0.5.5 and check_clippy to rust stable version #1247

Merged
merged 2 commits into from
Dec 21, 2023
Merged

ci: pin home dependency to 0.5.5 and check_clippy to rust stable version #1247

merged 2 commits into from
Dec 21, 2023

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Dec 20, 2023 •
edited
Loading

Description

Fixed 1.63 MSRV error by pinning home dependency to 0.5.5, and clippy error by changing check_clippy job to using rust stable version.

Notes to the reviewers

It's OK to use rust stable version for clippy because we already have a clippy.toml file to tell it which version of the clippy rules to check against.

Changelog notice

None

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Dec 20, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.3 milestone Dec 20, 2023
@notmandatory notmandatory changed the title ci: add clippy_check permissions.checks.write ci: pin home dev-dependency version to 0.5.5 and check_clippy to use rust stable version Dec 20, 2023
@notmandatory notmandatory changed the title ci: pin home dev-dependency version to 0.5.5 and check_clippy to use rust stable version ci: pin home dependency to 0.5.5 and check_clippy to use rust stable version Dec 20, 2023
@notmandatory notmandatory changed the title ci: pin home dependency to 0.5.5 and check_clippy to use rust stable version ci: pin home dependency to 0.5.5 and check_clippy to rust stable version Dec 20, 2023
This was referenced Dec 20, 2023
Merged
Merged
Merged
Merged
Merged
evanlinjin
evanlinjin approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e7fbc8b

@evanlinjin evanlinjin merged commit b5612f2 into bitcoindevkit:master Dec 21, 2023
12 checks passed
@nondiremanuel nondiremanuel mentioned this pull request Jan 1, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees

@notmandatory notmandatory

Labels
ci
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@notmandatory @evanlinjin