Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: apply loaded changeset to indexed_graph when loading a wallet from persistence #1246

Merged

Conversation

thunderbiscuit
Copy link
Member

Description

This PR applies the tx_graph from the changeset when loading a wallet from persistence. This ensures among other things that the revealed keychain indices get picked up by the new wallet. A test for this has been added/modified from an old test.

Notes to the reviewers

Changelog notice

Fix: loading a wallet from persistence now restores keychain indices.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory added the bug Something isn't working label Dec 19, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.4 milestone Dec 19, 2023
@notmandatory
Copy link
Member

This one will need to be rebased once #1247 has been merged, that will fix the clippy and 1.63.0 errors.

@thunderbiscuit thunderbiscuit force-pushed the fix-load-from-changeset branch from d64bdc9 to f4863c6 Compare December 21, 2023 02:56
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4863c6

Thanks for catching this large oversight of mine 😥

@evanlinjin evanlinjin merged commit 01698ae into bitcoindevkit:master Dec 26, 2023
12 checks passed
@notmandatory notmandatory modified the milestones: 1.0.0-alpha.4, 1.0.0-alpha.3 Dec 26, 2023
@notmandatory notmandatory mentioned this pull request Jan 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants