Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ComputeSighash #1038

Closed
Tracked by #86
, #87
...
danielabrozzoni opened this issue Jul 19, 2023 · 3 comments · Fixed by #1424
Closed
Tracked by #86
, #87
...

Remove ComputeSighash #1038

danielabrozzoni opened this issue Jul 19, 2023 · 3 comments · Fixed by #1424
Assignees
@ValuedMammal
Labels
api A breaking API change module-wallet
Milestone
1.0.0-alpha

Comments

@danielabrozzoni
Copy link
Member

Needs #1023

Use the rust-bitcoin methods instead, and contribute upstream if they're lacking. See #1023 (comment)
@danielabrozzoni danielabrozzoni mentioned this issue Jul 19, 2023
Merged
3 tasks
evanlinjin added a commit that referenced this issue Aug 4, 2023
@evanlinjin
Merge #1023: Update rust bitcoin
feafaac 
1da3b30 ci: Pin rustls to keep the MSRV (Daniela Brozzoni)
792b39f Explicitly deny multipath keys (Daniela Brozzoni)
b73385d Update wallet_electrum to rust-bitcoin 0.30.0 (Daniela Brozzoni)
3dac3f9 Update example_electrum to rust-bitcoin 0.30.0 (Daniela Brozzoni)
2949bdc Update example_cli to rust-bitcoin 0.30.0 (Daniela Brozzoni)
468d2a0 Update tmp_plan to rust-bitcoin 0.30.0 (Daniela Brozzoni)
b8ac16d Update coin_select to rust-bitcoin 0.30.0 (Daniela Brozzoni)
6c29e53 Update wallet_esplora and wallet_esplora_async to... ...rust-bitcoin 0.30.0 (Daniela Brozzoni)
6eb0795 Update crates/esplora to rust-bitcoin 0.30.0 (Daniela Brozzoni)
91b0f0b Update crates/electrum to bitcoin 0.30.0 (Daniela Brozzoni)
f4e3ba3 Update bdk to bitcoin 0.30.0 (Daniela Brozzoni)
853d361 Update bdk_chain to bitcoin 0.30.0 (Daniela Brozzoni)

Pull request description:

  ### Description

  Updates to rust-bitcoin 0.30.0 and miniscript 0.10.0

  Not covered in this PR:
  - #1036. Although the latter is deprecated, I think it's better if I update it in a separate PR, as this one is pretty big already.
  - #1037
  - #1038

  Heads up, I'm explicitly denying multipath descriptors until we have better tests for them. See the commit message of 23fba7a

  ### Changelog notice

  - Update to `rust-bitcoin` 0.30.0 and `miniscript` 10.0.0

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 1da3b30

Tree-SHA512: ff1457ed711f9f8cdb446ea10aaf124632f539c02406da94317d8dc38013b321217d3bdcb2df4bd72b2ed92116b52e9c6b98ee91d4d508a579c67449a7caa549
@notmandatory notmandatory added this to BDK Nov 13, 2023
@notmandatory notmandatory moved this to Todo in BDK Nov 13, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.4 milestone Nov 13, 2023
@nondiremanuel nondiremanuel mentioned this issue Nov 19, 2023
Closed
54 tasks
@nondiremanuel nondiremanuel mentioned this issue Dec 2, 2023
Closed
55 tasks
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@notmandatory notmandatory added module-wallet api A breaking API change labels Mar 18, 2024
@notmandatory
Copy link
Member

A likely small change but I think we should push to post 1.0 milestone.

@nondiremanuel
Copy link

Needs some more research to understand if it's needed for 1.0

@ValuedMammal
Copy link
Contributor

I'm willing to have a go at this.

@ValuedMammal ValuedMammal self-assigned this May 1, 2024
@ValuedMammal ValuedMammal mentioned this issue May 3, 2024
Merged
5 tasks
@nondiremanuel nondiremanuel moved this from Todo to In Progress in BDK May 7, 2024
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Jun 18, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValuedMammal ValuedMammal

Labels
api A breaking API change module-wallet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

refactor(wallet): Use Psbt::sighash_ecdsa for computing sighashes ValuedMammal/bdk
4 participants
@notmandatory @danielabrozzoni @nondiremanuel @ValuedMammal