Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bitcoin::FeeRate instead of bdk::FeeRate #1037

Closed
danielabrozzoni opened this issue Jul 19, 2023 · 3 comments
Closed

Use bitcoin::FeeRate instead of bdk::FeeRate #1037

danielabrozzoni opened this issue Jul 19, 2023 · 3 comments

Comments

@danielabrozzoni
Copy link
Member

danielabrozzoni commented Jul 19, 2023 •
edited
Loading

Needs #1023

Since bdk::FeeRate has a few helpful methods that bitcoin::FeeRate doesn't have (fee_wu, fee_vb etc), maybe we should submit a patch to rust-bitcoin first
@danielabrozzoni danielabrozzoni mentioned this issue Jul 19, 2023
Merged
3 tasks
@tcharding
Copy link
Contributor

tcharding commented Jul 19, 2023 •
edited
Loading

I had to think a bit to see if we supported this so I figured it was not discoverable enough :) rust-bitcoin/rust-bitcoin#1947

FTR you can use bitcoin::FeeRate as it is today, 1947 just adds convenience methods.

evanlinjin added a commit that referenced this issue Aug 4, 2023
@evanlinjin
Merge #1023: Update rust bitcoin
feafaac 
1da3b30 ci: Pin rustls to keep the MSRV (Daniela Brozzoni)
792b39f Explicitly deny multipath keys (Daniela Brozzoni)
b73385d Update wallet_electrum to rust-bitcoin 0.30.0 (Daniela Brozzoni)
3dac3f9 Update example_electrum to rust-bitcoin 0.30.0 (Daniela Brozzoni)
2949bdc Update example_cli to rust-bitcoin 0.30.0 (Daniela Brozzoni)
468d2a0 Update tmp_plan to rust-bitcoin 0.30.0 (Daniela Brozzoni)
b8ac16d Update coin_select to rust-bitcoin 0.30.0 (Daniela Brozzoni)
6c29e53 Update wallet_esplora and wallet_esplora_async to... ...rust-bitcoin 0.30.0 (Daniela Brozzoni)
6eb0795 Update crates/esplora to rust-bitcoin 0.30.0 (Daniela Brozzoni)
91b0f0b Update crates/electrum to bitcoin 0.30.0 (Daniela Brozzoni)
f4e3ba3 Update bdk to bitcoin 0.30.0 (Daniela Brozzoni)
853d361 Update bdk_chain to bitcoin 0.30.0 (Daniela Brozzoni)

Pull request description:

  ### Description

  Updates to rust-bitcoin 0.30.0 and miniscript 0.10.0

  Not covered in this PR:
  - #1036. Although the latter is deprecated, I think it's better if I update it in a separate PR, as this one is pretty big already.
  - #1037
  - #1038

  Heads up, I'm explicitly denying multipath descriptors until we have better tests for them. See the commit message of 23fba7a

  ### Changelog notice

  - Update to `rust-bitcoin` 0.30.0 and `miniscript` 10.0.0

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 1da3b30

Tree-SHA512: ff1457ed711f9f8cdb446ea10aaf124632f539c02406da94317d8dc38013b321217d3bdcb2df4bd72b2ed92116b52e9c6b98ee91d4d508a579c67449a7caa549
@danielabrozzoni danielabrozzoni mentioned this issue Sep 29, 2023
Closed
@danielabrozzoni
Copy link
Member Author

Closing in favor of #1136, which is the same issue, but better specified :)

@github-project-automation github-project-automation bot moved this to Done in BDK Sep 29, 2023
@notmandatory notmandatory removed this from BDK Oct 1, 2023
@notmandatory
Copy link
Member

oops! @danielabrozzoni sorry I forgot you already had this one open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@notmandatory @tcharding @danielabrozzoni