Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method names to mirror Rust bdk API #185

Merged

Conversation

thunderbiscuit
Copy link
Member

Fixes #181.

  1. get_network() is now network()
  2. get_transactions() is now list_transactions()

@thunderbiscuit thunderbiscuit self-assigned this Aug 18, 2022
@thunderbiscuit thunderbiscuit added this to the Release 0.9.0 milestone Aug 18, 2022
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 765662e

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I ACK'd this one too soon. Please also update the CHANGELOG with summary of changed function names.

@thunderbiscuit thunderbiscuit force-pushed the fix-builder-function-names branch from 765662e to 7228fa0 Compare August 18, 2022 18:22
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7228fa0

@thunderbiscuit thunderbiscuit force-pushed the fix-builder-function-names branch from 7228fa0 to a1165c9 Compare August 18, 2022 18:27
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReACK 7da1aaf

@thunderbiscuit thunderbiscuit merged commit aa00420 into bitcoindevkit:master Aug 18, 2022
@thunderbiscuit thunderbiscuit deleted the fix-builder-function-names branch November 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Naming differences between bindings and Rust API
2 participants