Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming differences between bindings and Rust API #181

Closed
thunderbiscuit opened this issue Aug 5, 2022 · 1 comment · Fixed by #185
Closed

Naming differences between bindings and Rust API #181

thunderbiscuit opened this issue Aug 5, 2022 · 1 comment · Fixed by #185
Assignees
@thunderbiscuit
Labels
discussion Issue requires some discussion first
Milestone
Release 0.9.0

Comments

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Aug 5, 2022 •
edited
Loading

I believe there are two naming differences between the bindings API and the Rust API on the TxBuilder:

  1. Our TxBuilder uses get_transactions() instead of the bdk list_transactions() method
  2. Our TxBuilder uses get_network() instead of the bdk network() method

Fixing these would create breaking changes but I think we should continue to strive for name parity with the upstream library if we can.
@thunderbiscuit thunderbiscuit added this to the Release 0.9.0 milestone Aug 5, 2022
@thunderbiscuit thunderbiscuit changed the title Rename get_transactions to list_transactions to mirror bdk API Naming differences between bindings and Rust API on TxBuilder Aug 5, 2022
@thunderbiscuit thunderbiscuit added the discussion Issue requires some discussion first label Aug 5, 2022
@notmandatory
Copy link
Member

Good idea! I agree.

@notmandatory notmandatory moved this to Todo in BDK-Bindings Aug 17, 2022
@thunderbiscuit thunderbiscuit changed the title Naming differences between bindings and Rust API on TxBuilder Naming differences between bindings and Rust API Aug 17, 2022
@thunderbiscuit thunderbiscuit self-assigned this Aug 17, 2022
@thunderbiscuit thunderbiscuit mentioned this issue Aug 17, 2022
Merged
@notmandatory notmandatory moved this from Todo to In Progress in BDK-Bindings Aug 18, 2022
Repository owner moved this from In Progress to Done in BDK-Bindings Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thunderbiscuit thunderbiscuit

Labels
discussion Issue requires some discussion first
Projects
BDK-Bindings
Archived in project
Milestone
Release 0.9.0
Development

Successfully merging a pull request may close this issue.

Fix method names to mirror Rust bdk API thunderbiscuit/bdk-ffi
2 participants
@notmandatory @thunderbiscuit