add replacement cycling #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
Draft
pinheadmz
reviewed
Jun 7, 2024
There was a problem hiding this comment.
@mplsgrant are you able to get this scenario running in warnet? I got a connect_nodes error at first then rebased on main, now I get a sync_all error:
│ 2024-06-07T14:32:33+0000 - INFO - Traceback (most recent call last): │
│ 2024-06-07T14:32:33+0000 - INFO - File "/root/warnet/src/test_framework/test_framework.py", line 131, in main │
│ 2024-06-07T14:32:33+0000 - INFO - self.run_test() │
│ 2024-06-07T14:32:33+0000 - INFO - File "/root/warnet/src/scenarios/replacement_cycling.py", line 430, in run_test │
│ 2024-06-07T14:32:33+0000 - INFO - self.generatetoaddress(self.nodes[0], nblocks=101, │
│ 2024-06-07T14:32:33+0000 - INFO - File "/root/warnet/src/test_framework/test_framework.py", line 692, in generatetoaddress │
│ 2024-06-07T14:32:33+0000 - INFO - sync_fun() if sync_fun else self.sync_all() │
│ 2024-06-07T14:32:33+0000 - INFO - ^^^^^^^^^^^^^^^ │
│ 2024-06-07T14:32:33+0000 - INFO - File "/root/warnet/src/test_framework/test_framework.py", line 746, in sync_all │
│ 2024-06-07T14:32:33+0000 - INFO - self.sync_blocks(nodes) │
│ 2024-06-07T14:32:33+0000 - INFO - File "/root/warnet/src/test_framework/test_framework.py", line 715, in sync_blocks │
│ 2024-06-07T14:32:33+0000 - INFO - assert (all([len(x.getpeerinfo()) for x in rpc_connections]))
src/scenarios/replacement-cycling.py
Outdated
| @@ -0,0 +1,439 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
file needs to be named with underscore not hyphen. rpc_test.py fails locally for me without that fix, dunno why CI is ok with it 🤷
There was a problem hiding this comment.
I thought the scenarios test would have caught that.
Yes, we got a version of it working just fine on this branch. There shouldn't be any differences that |
mplsgrant
force-pushed
the
2024-05-add-replacement-cycling
branch
from
f19a1d6
to
7bfe435
Compare
|
I rebased this. |
mplsgrant
force-pushed
the
2024-05-add-replacement-cycling
branch
from
b62cda2
to
43a2d72
Compare
|
Rebased on main |
willcl-ark
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Can we add a CI test for this? I suspect it may fail, as I find locally:
2024-06-21T10:29:59+0000 - INFO - Started server
* Serving Flask app 'warnet.server'
* Debug mode: on
2024-06-21T10:30:00+0000 - INFO - Logging started
2024-06-21T10:30:00+0000 - INFO - Started server
2024-06-21T10:30:00+0000 - WARNING - * Debugger is active!
2024-06-21T10:30:06+0000 - DEBUG - {'jsonrpc': '2.0', 'method': 'scenarios_run', 'params': {'scenario': 'replacement_cycling', 'additional_args': [], 'network': 'warnet'}, 'id': 1}
2024-06-21T10:30:06+0000 - DEBUG - Running ['/usr/local/bin/python3', '/root/warnet/src/scenarios/replacement_cycling.py', '--network=warnet']
2024-06-21T10:30:06+0000 - INFO - Unexpected exception caught during testing
2024-06-21T10:30:06+0000 - INFO - Traceback (most recent call last):
2024-06-21T10:30:06+0000 - INFO - File "/root/warnet/src/test_framework/test_framework.py", line 130, in main
2024-06-21T10:30:06+0000 - INFO - self.setup()
2024-06-21T10:30:06+0000 - INFO - File "/root/warnet/src/warnet/test_framework_bridge.py", line 60, in setup
2024-06-21T10:30:06+0000 - INFO - self.warnet = Warnet.from_network(self.options.network)
2024-06-21T10:30:06+0000 - INFO - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-06-21T10:30:06+0000 - INFO - File "/root/warnet/src/warnet/warnet.py", line 137, in from_network
2024-06-21T10:30:06+0000 - INFO - self.graph = networkx.read_graphml(
2024-06-21T10:30:06+0000 - INFO - ^^^^^^^^^^^^^^^^^^^^^^
2024-06-21T10:30:06+0000 - INFO - File "/usr/local/lib/python3.12/site-packages/networkx/utils/decorators.py", line 770, in func
2024-06-21T10:30:06+0000 - INFO - return argmap._lazy_compile(__wrapper)(*args, **kwargs)
2024-06-21T10:30:06+0000 - INFO - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-06-21T10:30:06+0000 - INFO - File "<class 'networkx.utils.decorators.argmap'> compilation 5", line 3, in argmap_read_graphml_1
2024-06-21T10:30:06+0000 - INFO - import gzip
2024-06-21T10:30:06+0000 - INFO -
2024-06-21T10:30:06+0000 - INFO - File "/usr/local/lib/python3.12/site-packages/networkx/utils/decorators.py", line 193, in _open_file
2024-06-21T10:30:06+0000 - INFO - fobj = _dispatch_dict[ext](path, mode=mode)
2024-06-21T10:30:06+0000 - INFO - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-06-21T10:30:06+0000 - INFO - FileNotFoundError: [Errno 2] No such file or directory: '/root/.warnet/warnet/warnet/graph.graphml'
I can get it to run, but only if I run a manual warnet first. This I presume creates the config dir and copies the graph into it which this test is looking for.
Perhaps this test should be explicit about which graph it is using as is done in the other tests which would load and copy the graph correctly?
|
@willcl-ark Happy to add a CI for this. When the scenario failed locally, were these the steps you took? just start
just p &
warcli scenarios run replacement_cycling |
mplsgrant
force-pushed
the
2024-05-add-replacement-cycling
branch
2 times, most recently
from
4a370b3
to
3754708
Compare
Author: Greg Sanders <[email protected]> Date: Wed May 29 11:30:39 2024 -0400
delint fix spelling slightly modify some log entries
mplsgrant
force-pushed
the
2024-05-add-replacement-cycling
branch
from
3754708
to
4325583
Compare
|
Closing in favor of #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft
Want to make a CI test for this; waiting on #384
Issue
I can not run ariard's replacement cycling test in Warnet.
Cause
A number of the test framework components available in Bitcoin Core have not been ported into Warnet.
Solution
Add the replacement cycling test as a scenario.
Wins
The test runs without meaningful augmentation. This is great because it points us in a direction of copy/pasting tests that run today in Core's functional test framework. We can then augment the tests to work in realistic environments with lightning nodes and other future tank types.
Depends on
#371