add connect_nodes #371
Merged
add connect_nodes #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplsgrant
force-pushed
the
2024-05-connect-nodes
branch
from
a3bceac
to
8456903
Compare
This was referenced May 27, 2024
Closed
Draft
mplsgrant
force-pushed
the
2024-05-connect-nodes
branch
from
8456903
to
8e3edb3
Compare
pinheadmz
reviewed
Jun 4, 2024
mplsgrant
force-pushed
the
2024-05-connect-nodes
branch
5 times, most recently
from
48a99b1
to
b88fde5
Compare
mplsgrant
force-pushed
the
2024-05-connect-nodes
branch
from
b88fde5
to
71cdbdf
Compare
pinheadmz
reviewed
Jun 6, 2024
|
this is good progress for #36 |
pinheadmz
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
ACK 5d83415
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK 5d834156ddab6656c68acf2754161046d31c647b
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmZiEoUACgkQ5+KYS2KJ
yTpV9g//U/3pTbZcECG9eixEhb10nRzhyDDYE7gbFN2dOdrqC9DbIBQUWODkIsBd
DkZxkxtFtObgO7jPU35torQ2FOMIgUAL8ZdnBG/5ANFrd5ef+fYmsoL+HFJ8b0H8
9dXpFkg1UzNnPGA/XIV2b/dg9ErRg+yxR7W3+3uf392mMPUn0DLwgL1x4HUsuzux
OYt736AATeWoQxMQjD/ReiCDfrTxwXJGbbhqcvb5sojdg1yBn4lsXemOWm8D8QPg
JHa9wOgDWAm4EGIDbXZTl0huN0xV5t9ogbUTRM+nT9cneUzDdvhBC1JiQTgqVfqw
KySGave/4EoVoIZtgYVBYUCZ3BD3bwA4nvbMkZOPvhet8T+9/EghxIimTcF2DyGz
NYeqHjGHD0Xb9QLY/vAYj35lyHZX4yi86tvxUSFa/iwEXmA1fi9BETzkqHXPjO9Z
hObAiVhMy7NuZs6UOqeKX02ixbMtTI0Q5dGs8tQyuSg2AKnpUZ9zl76uKNsh3QlF
nPiOXA/KLu64N4Q/W9vJA18rrGzfNbMDn58WzoFPMDFbbPsd+T2N/7/V5JGM1/Gp
X2YxUdlUTECiGacxnBOLrvATe+bHg2zpRtFwBjhjx73K1z9inC1nPsMMCFPuOCLB
wS9XH7yxIKydyfgXxbf6PWT5CIpEG9mbS/9M4eKOsM/aZtZsbXE=
=ghMN
-----END PGP SIGNATURE-----
pinheadmz's public key is on keybase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Running
connect_nodesfrom the Test Framework fails.Cause
connect_nodesassumes bitcoind processes running viapopen, and they don't expect to see dns-style addresses in place of ip addresses.Solution
Update the backend abstract class, and align the original
connect_nodesfunction with the ip configurations we use in k8s.