Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different trade fee for taker and maker #65

Closed
ManfredKarrer opened this issue Jan 4, 2019 · 11 comments
Closed

Use different trade fee for taker and maker #65

ManfredKarrer opened this issue Jan 4, 2019 · 11 comments

Comments

@ManfredKarrer
Copy link
Member

This is a Bisq Network proposal. Please familiarize yourself with the submission and review process.

Related to #64 I would like to discuss to change the maker and taker fee.
Currently they are both 0,2%. Some users commented that the maker fee should be lower to create more incentives for makers. There are also some privacy and convenience considerations where the taker has more advantages. One aspect to consider is that the taker pays the miner fee for both the deposit tx and the payout tx, so he gets a higher total fee if the tx fee is taked into account. This fee is currnetly rather low but could become a considerable factor once miners fees become more expensive again.

I would suggest to change the maker fee to 0,1% (fixed percentage without using calculation with the market distance) and the taker fee 0,3%.

Please upvote if you support that or downvote if not. If you have other suggestions or feedback please post it below!

Specially from pro traders feedback is very welcome!

@justpaulgmx
Copy link

Thank for revisiting this issue. I think it is an important change. As a contributor, I enthusiastically support the proposal.

As a project contributer, I think there is another issue for makers worth considering, the inability to edit as maker. They can end up with multiple listing fees for an offer that never sold. Would it be possible to eliminate listing fees and increase fee for successful sale?

@clearwater-trust
Copy link
Member

I agree with @justpaulgmx - i understand the listing fee is to discourage order book spamming, also, it is currently possible to edit an offer's price without sacrificing the fee. However, I think the listing fee provides a frightening barrier to new traders. They can't list a trade without risking the fee. I think listing new trades should take priority over order book spamming at this stage.

@ManfredKarrer
Copy link
Member Author

I consider the proposal approved with 7 votes pro and 0 votes against it.

ManfredKarrer added a commit to ManfredKarrer/bisq that referenced this issue Jan 7, 2019
- Reduce maker fee to 0,1%, increase take fee to 0,3%

As approved by proposal
bisq-network/proposals#65
@ManfredKarrer
Copy link
Member Author

Implemented with bisq-network/bisq#2213

@ghost
Copy link

ghost commented Jan 29, 2019

Trying to take into account the above comments,
I wonder if Bisq could'nt implement some kind of PoW for the offers (to avoid spam),
and only take fees for successful offers ?

@justpaulgmx
Copy link

I love the idea of adding some simple monero mining JavaScript as a spam solution in place of the current (reduced fee) for market makers.

It would be wise to create our own mining pool and store the funds in moneroj until needed for any possible monero trade fraud where the arbitrator made an error. Looks like around 9/10 transactions are BTC/XMR pairs recently.

Would you be willing to create a new issue for this proposal as this one is now closed? Would that be the best idea Manfred?

Paul.

@ManfredKarrer
Copy link
Member Author

Feel free to make new proposal. JavaScript cannot be used in Bisq.

@justpaulgmx
Copy link

Great. Harry MacFinned, do you want to do that?

Good point Manfred. I understand the reason but that will complicate / elongate this proposal.

Does anyone know of a Java based monero miner? If not, I'm guessing a C based miner could be integrated?

Manfred, could you share more of your thoughts on the right technical execution of this?

I could help with some of this but integration into a Java app would be new for me.

@ManfredKarrer
Copy link
Member Author

@justpaulgmx I am not very convinced that this is a good idea. Adding such adds risks and I am pretty sure soem user would not like that. But feel free to write up a more detailed proposal.

@ghost
Copy link

ghost commented Jan 31, 2019

@justpaulgmx
I was only thinking out loud, for purpose of discussion.
atm Bisq has a solution which proves to be functional and works since several years.
Proposing something potentially better needs to be rather careful.
And also it needs significant support from users ... which is not very apparent right now.

@justpaulgmx
Copy link

Fair comment. While I love mining pow as micro payments, I agree that public perception is currently negative and we should take a wait and see approach. I'll create a new proposal if/when appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants