Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 12 #522

Closed
ghubstan opened this issue Apr 3, 2020 · 13 comments
Closed

For Cycle 12 #522

ghubstan opened this issue Apr 3, 2020 · 13 comments
Assignees
Labels
was:not submitted Indicates that a compensation request was not submitted for DAO voting
Milestone

Comments

@ghubstan
Copy link

ghubstan commented Apr 3, 2020

Summary

Specify the total amount of BSQ you are requesting:

  • BSQ requested: BSQ requested: 5475 USD / 0.56 = 9777 BSQ

Contributions delivered

  • Investigated issue 3918 and found sources of unnecessarily large resident memory use by JVM and Linux glibc. @freimair implmented first finding of that investigation which reduces the JVM's MAXRam setting from 128 GB to 4 GB in PR 4048, and the change reduced resident memory use on a clean Bisq installation on Ubuntu18 from ~ 4.8GB to ~1.7 GB. Other tested ways of reducing resident memory usage by ~ 500MB are described in 3918, if needed in the future. Also added troubleshooting tips under the heading Bisq is using too much RAM on the bisq wiki.
    Requesting 5,357 BSQ = 3,000 USD

  • Improve AvoidStandyModeService -- PR 4060
    This change reduced disk reads by ~ 50% according to @freimair , and about 1 GB of resident memory allocation per hour according to my testing and profiling. This was accomplished by running native suspend/sleep inhibitors on Linux and OXS, instead of playing the silent audio file.
    Requesting 1,250 BSQ = 700 USD

  • Reduce Dependency Conflicts -- Issue 4086
    This is a work in progress. PRs 4089, 4108 have been merged to eliminate dependency conflicts among grpc, gson, apache commons, apache httpclient/core, logback, and slf4j libraries.
    Requesting 625 BSQ = 350 USD

  • Begin gRPC daemon and cli development based on existing POC. The first merged PR 4096 pulled protobuf definitions files out the :common and :core subprojects, into a new :proto subproject. This eliminated :cli's direct dependency on core, and transitive dependencie's within :common. It also reduces :common and :core incremental build times. The second merged PR 4097 hid netty debug stacktraces in the :cli, and introduced other changes to tidy of :cli, in preparation for the next phase of development currently in progress (not delivered): implementing SSL/TLS and cli authentication; wallet encryption / decryption is next
    Requesting 2143 BSQ = 1,200 USD

  • Test release v1.3.2. Fixed issue #4158 in PR 4161. The bug was causing a test failure, blocking full gradle builds. Also tested Funds Managenemt, Wallet Managment, and Application Setttings
    Requesting 402 BSQ = 225 USD

Contributions in progress

  • Preparation for the next phase of rpc :cli development: implementing SSL/TLS and cli authentication; wallet encryption / decryption is next.

Roles performed

Provide links to your monthly report on any roles you are responsible for.

@cbeams cbeams added this to the Cycle 12 milestone Apr 7, 2020
@MwithM
Copy link
Contributor

MwithM commented Apr 20, 2020

Proposal phase has ended and it looks that this request is still as WIP and not sent to DAO vote.
I'm closing as not submitted. Submit again for next cycle.

@MwithM MwithM closed this as completed Apr 20, 2020
@MwithM MwithM added the was:not submitted Indicates that a compensation request was not submitted for DAO voting label Apr 20, 2020
@ghubstan
Copy link
Author

ghubstan commented Apr 20, 2020

@MwithM ,
Please re-open this, as these works in progress were waiting for v1.3.2 to be linked from the Bisq download page, which happened today. Thanks.

@ripcurlx
Copy link
Contributor

@MwithM ,
Please re-open this, as these works in progress were waiting for v1.3.2 to be linked from the Bisq download page, which happened today. Thanks.

If something is merged to master and has the is:priorty label it is up for compensation. There is no need to wait for a regular release anymore.

@MwithM MwithM reopened this Apr 20, 2020
@ripcurlx
Copy link
Contributor

@ghubstan the problem js, that the DAO is already in the break before the blind vote-phase which doesn't allow new proposals for this cycle anymore, so you have to wait for next cycle unfortunately.

@ghubstan
Copy link
Author

@ripcurlx , That is more than a little burdensome on me. I heard v1.3.2 was to be released late last week, but I held off on turning my WIPs to delivered until the right time... then the instant it's released, my request is closed before WIP can be switched to delivered.
I "have" to wait?
And how does one avoid this situation?
Why wasn't there a heads up about when v1.3.2 was released?

@ghubstan
Copy link
Author

@MwithM > "If something is merged to master and has the is:priorty label it is up for compensation. There is no need to wait for a regular release anymore."

I did not know that. I thought comp was paid only for work downloaded by end-users. I heard this many times from @cbeams

@ghubstan
Copy link
Author

ghubstan commented Apr 20, 2020

Someone opened it! I'm very grateful. But is it still blocked from this cycle's voting?

@ripcurlx
Copy link
Contributor

I did not know that. I thought comp was paid only for work downloaded by end-users. I heard this many times from @cbeams

We had this requirement in the past, but it was already change a couple of months (maybe even a year ago)?

@ghubstan ghubstan changed the title [WIP] For Cycle 12 For Cycle 12 Apr 20, 2020
@ripcurlx
Copy link
Contributor

Why wasn't there a heads up about when v1.3.2 was released?

I mentioned it in the #dev and #testing channel, but the main problem you are facing is that no matter if this issue is open or not is the fact, that you need to submit the compensation request to the DAO within the Bisq client and there the state is already in the break before the blind vote-phase, where no proposal can be added anymore.

@MwithM
Copy link
Contributor

MwithM commented Apr 20, 2020

I did open, but there's no use in reopening this issue because it can't be sent to DAO vote. The time to submit requests to DAO (proposal phase) has passed. Sorry.

Discussion can be continued here even if an issue is closed.

@MwithM MwithM closed this as completed Apr 20, 2020
@dmos62
Copy link

dmos62 commented Apr 20, 2020

@MwithM what's a good way to stay up to date with CR deadlines? bisq.network/calendar?

@MwithM
Copy link
Contributor

MwithM commented Apr 20, 2020

This calendar updates the deadline to submit compensation requests for review, which is a week before the end of proposal phase.

https://bisq.wiki/Compensation#Announce_request_submission_deadline

@sqrrm
Copy link
Member

sqrrm commented Apr 28, 2020

There are some inconsistencies with the vote result calculation for cycle 12. We are looking into it. Please avoid moving any BTC in your BSQ wallet for now, they might actually be BSQ that failed to get colored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was:not submitted Indicates that a compensation request was not submitted for DAO voting
Projects
Archived in project
Development

No branches or pull requests

6 participants